Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2179877rwi; Fri, 21 Oct 2022 00:14:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7rpj4fmDT5XCSYQ1/Y1cADYKR1frfp1ruvcXRto9WyHMwYiVUIFuIyT2Hdhoc9WYtfxUQe X-Received: by 2002:a17:907:7f92:b0:78d:ed9c:d86f with SMTP id qk18-20020a1709077f9200b0078ded9cd86fmr14258065ejc.251.1666336497723; Fri, 21 Oct 2022 00:14:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666336497; cv=none; d=google.com; s=arc-20160816; b=vMathUElvG+i3IYE9DsUQSG0q51yPXOLbmp7LcbLuGY83gzfotn89QLS0zaV60CONv zMZihk8yOlldY6kx+WZ1EASsWvXOWbiV+/6bLISs9UIVFaGrNUke+t3z1ILr4wC0wWI2 Mf66DwLWPHh+eLzCELrdRMfYlhC3Zqs7VRDPiAzSOXdWvJr10Y87DHHrVjsuMlvnxwSq qvwllpRVycnrycGsR/GmgbwpEoHPpZk+OgsYzotaGL2X8cpH2Fnx0ZmTCCYcpoB5Tknf HViLa0oAFPSAf0NeN9PXOXOx9VlwN6QjuayqLgTcd6XBqLOR8+iuSDAi0G0OEzMT8QgM h+Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=7VsXhOdAaVq8huGRSZeeIaJUnPkRRvpMQzTfQzaBGKM=; b=BjBeEN5nfCRr9XeA5YVTW7mSqfiZq/bTlz3f35IbUlS1aN5O+Rgr/MYkv9vIoLpi18 wG8o0MaDo91o+CmwPERSgub/5P0oF3sn3/3Oaaab0jQBypgF4ySzLHvcPDP1Le8+/sQQ G3aVPhsiKyp20dyobfro7mNRY05OGJa15by4KczXFDhGgfXNnWuDFXKA7EMFuW/ho8Z7 StKlBKDlwKaa3DRczqy1UecpAV8w4haftX8czahIIxBuypMYyxQPSuV16okHSSt1LA2m uWORfV63mDGeSixVyBZWvT7MkF5+A3+QCwAvXRs/s+Yvd/dEFAhbK43u8SKUa/y3f9pO wUCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e4+Sq01B; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id he9-20020a1709073d8900b0078316f0b5f8si22413759ejc.88.2022.10.21.00.14.36; Fri, 21 Oct 2022 00:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e4+Sq01B; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbiJUHAq (ORCPT + 65 others); Fri, 21 Oct 2022 03:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbiJUHAn (ORCPT ); Fri, 21 Oct 2022 03:00:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D541F96222; Fri, 21 Oct 2022 00:00:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 924ACB80B3C; Fri, 21 Oct 2022 07:00:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B9DCC433C1; Fri, 21 Oct 2022 07:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666335639; bh=EmSAQ2/Kn6SeX4zoucILX3L8Z9heMrfHbWNEHW6Q2l4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=e4+Sq01BCa8YRnrios+qESSSuSqKTOcGxqrwWxeMJaRt1ROo5Ty4gYnvGXmsNiea1 ju9/hoH+UswIh1q4sAHPVG9n7felNKOc4zwBfrJkGV4UqHiIqkOjc62uEsMdQbL88O z+RavP3ybXkp9+jJ4OPRoZiY62Qwu/eEe+dyGzYd0VzlP9kuovrI3rep+HUACxo+Ip d12dFkpvzpWSw6m+4aKd8aBZTyb8040iY2ZYVYfjJpkSWAitcjD8/uRT3s90H+DbyU JpsaiLJrn2VFetrgjpTmBdMPsxY1iBjrrMeEOrQveGxDzVrrsYEBFqWC+WG1XGAnnP apwFXSCjZvYsw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] wifi: rt2x00: use explicitly signed or unsigned types From: Kalle Valo In-Reply-To: <20221019155541.3410813-1-Jason@zx2c4.com> References: <20221019155541.3410813-1-Jason@zx2c4.com> To: "Jason A. Donenfeld" Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Jason A. Donenfeld" , Andrew Morton , Andy Shevchenko , Stanislaw Gruszka , Helmut Schaa User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166633563389.6242.13987912613257140089.kvalo@kernel.org> Date: Fri, 21 Oct 2022 07:00:37 +0000 (UTC) X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Jason A. Donenfeld" wrote: > On some platforms, `char` is unsigned, but this driver, for the most > part, assumed it was signed. In other places, it uses `char` to mean an > unsigned number, but only in cases when the values are small. And in > still other places, `char` is used as a boolean. Put an end to this > confusion by declaring explicit types, depending on the context. > > Cc: Andrew Morton > Cc: Andy Shevchenko > Cc: Stanislaw Gruszka > Cc: Helmut Schaa > Cc: Kalle Valo > Signed-off-by: Jason A. Donenfeld > Acked-by: Stanislaw Gruszka Patch applied to wireless.git, thanks. 66063033f77e wifi: rt2x00: use explicitly signed or unsigned types -- https://patchwork.kernel.org/project/linux-wireless/patch/20221019155541.3410813-1-Jason@zx2c4.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches