Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     <linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH 06/50] wifi: ath12k: add core.h
References: <20220812161003.27279-1-kvalo@kernel.org>
        <20220812161003.27279-7-kvalo@kernel.org>
        <f0c1dad2-cb69-cc7e-5cc8-892b4a3fa9d9@quicinc.com>
Date:   Fri, 21 Oct 2022 13:58:38 +0300
In-Reply-To: <f0c1dad2-cb69-cc7e-5cc8-892b4a3fa9d9@quicinc.com> (Jeff
        Johnson's message of "Fri, 12 Aug 2022 17:16:10 -0700")
Message-ID: <871qr1l9y9.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

>> +struct ath12k_skb_cb {
>> +	dma_addr_t paddr;
>> +	u8 flags;
>> +	u32 cipher;
>> +	struct ath12k *ar;
>> +	struct ieee80211_vif *vif;
>> +	dma_addr_t paddr_ext_desc;
>> +} __packed;
>
> Usage of __packed seems incorrect since this is not an ABI buffer, and
> packing will potentially result in some members being unaligned
> (ath11k has struct ath11k_skb_cb packed as well).
>
> Suggest removing __packed and using pahole to find the ideal layout
> since the only concern is that this does not exceed
> IEEE80211_TX_INFO_DRIVER_DATA_SIZE

Praneesh fixed this in ath12k-bringup:

1a458fd07d47 ath12k: remove __packed from the ath12k_skb_cb struct

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches