Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     <linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH 07/50] wifi: ath12k: add dbring.c
References: <20220812161003.27279-1-kvalo@kernel.org>
        <20220812161003.27279-8-kvalo@kernel.org>
        <d9403714-d7ef-3a7c-0448-e5b2b0a60c34@quicinc.com>
Date:   Fri, 21 Oct 2022 14:06:04 +0300
In-Reply-To: <d9403714-d7ef-3a7c-0448-e5b2b0a60c34@quicinc.com> (Jeff
        Johnson's message of "Mon, 15 Aug 2022 12:55:57 -0700")
Message-ID: <87v8odjv1f.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 8/12/2022 9:09 AM, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> (Patches split into one patch per file for easier review, but the final
>> commit will be one big patch. See the cover letter for more info.)
>>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

[...]

>> +static int ath12k_dbring_fill_bufs(struct ath12k *ar,
>> +				   struct ath12k_dbring *ring,
>> +				   gfp_t gfp)
>> +{
>> +	struct ath12k_dbring_element *buff;
>> +	struct hal_srng *srng;
>> +	int num_remain, req_entries, num_free;
>> +	u32 align;
>> +	int size, ret;
>> +
>> +	srng = &ar->ab->hal.srng_list[ring->refill_srng.ring_id];
>
> there are several references to ar->ab in this function.
> suggest being consistent with ath12k_dbring_bufs_replenish() and define:
> 	struct ath12k_base *ab = ar->ab;
> and then s/ar->ab/ab/ in those accesses
>
> this suggestion applies to other functions below since there are
> multiple functions which have multiple ar->ab dereferences

Praneesh fixed this:

c568d8bc26de ath12k: convert payload[0] to payload[], use ab variable and fix __ath12k_dbg() signature


>> +int ath12k_dbring_buf_setup(struct ath12k *ar,
>> +			    struct ath12k_dbring *ring,
>> +			    struct ath12k_dbring_cap *db_cap)
>> +{
>> +	struct ath12k_base *ab = ar->ab;
>> +	struct hal_srng *srng;
>> +	int ret;
>> +
>> +	srng = &ab->hal.srng_list[ring->refill_srng.ring_id];
>> +	ring->bufs_max = ring->refill_srng.size /
>> +		ath12k_hal_srng_get_entrysize(ab, HAL_RXDMA_DIR_BUF);
>> +
>> +	ring->buf_sz = db_cap->min_buf_sz;
>> +	ring->buf_align = db_cap->min_buf_align;
>> +	ring->pdev_id = db_cap->pdev_id;
>> +	ring->hp_addr = ath12k_hal_srng_get_hp_addr(ar->ab, srng);
>> +	ring->tp_addr = ath12k_hal_srng_get_tp_addr(ar->ab, srng);
>
> s/ar->ab/ab/ in both of the above since you already have ab = ar->ab

This is still not fixed.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches