Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "ath12k\@lists.infradead.org" <ath12k@lists.infradead.org>
Subject: Re: [PATCH 12/50] wifi: ath12k: add dp.h
References: <20220812161003.27279-1-kvalo@kernel.org>
        <20220812161003.27279-13-kvalo@kernel.org>
        <0eabd6c1b3ca4d8a8152ad5b4f3efee6@realtek.com>
        <87leqxag07.fsf@kernel.org>
Date:   Fri, 21 Oct 2022 14:45:30 +0300
In-Reply-To: <87leqxag07.fsf@kernel.org> (Kalle Valo's message of "Mon, 05 Sep
        2022 20:27:20 +0300")
Message-ID: <878rl9jt7p.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Kalle Valo <kvalo@kernel.org> writes:

>>> +struct htt_srng_setup_cmd {
>>> +	u32 info0;
>>> +	u32 ring_base_addr_lo;
>>> +	u32 ring_base_addr_hi;
>>> +	u32 info1;
>>> +	u32 ring_head_off32_remote_addr_lo;
>>> +	u32 ring_head_off32_remote_addr_hi;
>>> +	u32 ring_tail_off32_remote_addr_lo;
>>> +	u32 ring_tail_off32_remote_addr_hi;
>>> +	u32 ring_msi_addr_lo;
>>> +	u32 ring_msi_addr_hi;
>>> +	u32 msi_data;
>>> +	u32 intr_info;
>>> +	u32 info2;
>>> +} __packed;
>>> +
>>
>> Should they be '__le32' instead of 'u32'?
>>
>> This struct is used to fill data of ath12k_htc_send(), and the fields of
>> htc header are __le32: 
>>
>> struct ath12k_htc_hdr {
>> 	__le32 htc_info;
>> 	__le32 ctrl_info;
>> } __packed __aligned(4);
>>
>> If above is correct, some struct(s) related to ath12k_htc_send() have
>> similar problems:
>> struct htt_ver_req_cmd
>> struct htt_ppdu_stats_cfg_cmd
>> struct htt_rx_ring_selection_cfg_cmd
>> struct htt_ext_stats_cfg_cmd
>> struct htt_tx_ring_selection_cfg_cmd  (miss __packed)
>
> Good catch, we'll fix those and the missing __packed. Thanks for the review!

I fixed these in:

efc72b2aa34c wifi: ath12k: dp: convert htt cmd structs to __le32

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches