Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2667044rwi;
        Fri, 21 Oct 2022 06:38:32 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4TBXFJfG7UHEtkqONBUYTbElYXXnwMm9dmtVOIMNP+7rlzkBN4N4sOZ8vpZtHmoeRffJSc
X-Received: by 2002:a05:6402:4282:b0:459:befa:c79c with SMTP id g2-20020a056402428200b00459befac79cmr17721502edc.23.1666359512413;
        Fri, 21 Oct 2022 06:38:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666359512; cv=none;
        d=google.com; s=arc-20160816;
        b=EfK407qaeqDg3Clq1swCwL3JLvBn2kPI6Ktf//oyeUvau+ei6rZMCKPA/yPl309AUF
         9C8Hkey/fCTO/gRxBYvKECL2crIblgHI1NbVooqPTHpQvoUd2XyPez9IZYrybZ3BHJBG
         uHAekbaghZ9JDbMFvmHOp0yG3KI8aIQEr5iFzAkYHZOcu6MW+hgf7/b1nDLdlxFjyfpq
         DjhQKCZmxghr7PzvaK4zFF7Z1B05DOi8LFYzFD22yeyN58SIAhh2nNFXfL9ffXuZiDmm
         Y1sebEZ3HGiHoTEQ5CH2UInlkxkrJb8jIN3S+vuvmYJJunJykqNvL/yCjPn977bSpmK8
         xAHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent
         :content-transfer-encoding:references:in-reply-to:date:to:from
         :subject:message-id:dkim-signature;
        bh=AAvfJJFVhJ6XeQFgLxgGQ1veyEOuryBX77FqDnPvIaw=;
        b=0x+KmrhjlkRfZd60kFDuE/avW0ahdPToQxmgcvPfRRcd/t2nI9j05M6k4gtwE2BeAI
         bLQfETH1v2W9ww7jKvjIuhjVbXc3wLk7gnq1rTqJ2DbFW46EayvCEQ0NaO0eSUPv/3nC
         1dgoIoPZjI39ptjpQSTTeeUI+F1qv4YhxOIbSqnYV4NA6qAfSVKD/fmuyXdHAX5kUScU
         RdWhH3nCb0gsOJHr/GGd2evlVoUBYS6F/DEjUC/lfuA5tPe1ZU6kmWYrzsTsFFn8hTnr
         rWxgcoBMElumiqJrc8g1fGXXC4xaWn7kPk/J9ifGk3YsxN9DiBNMwxboZKyn9Vi3b/Z0
         S9mQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@sipsolutions.net header.s=mail header.b="SJ/fkpPw";
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id qw5-20020a1709066a0500b0078df6780adfsi18092407ejc.22.2022.10.21.06.38.14;
        Fri, 21 Oct 2022 06:38:32 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@sipsolutions.net header.s=mail header.b="SJ/fkpPw";
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230407AbiJUNRq (ORCPT <rfc822;mudongliangabcd@gmail.com>
        + 65 others); Fri, 21 Oct 2022 09:17:46 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54032 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230307AbiJUNR2 (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Fri, 21 Oct 2022 09:17:28 -0400
Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5EB026D92E;
        Fri, 21 Oct 2022 06:17:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding:
        Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender:
        Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:
        Resent-Cc:Resent-Message-ID; bh=AAvfJJFVhJ6XeQFgLxgGQ1veyEOuryBX77FqDnPvIaw=;
        t=1666358239; x=1667567839; b=SJ/fkpPwoyDY20N8O8pt4W5Fj7KfQ5xEmjN0H98y7b2t3wY
        Q7W7aeB4oFf57bXtK0Di+EEnG51txDj99eqJ4WLTSJmul9e4o6lkbQdBENWKfRbbH96fojiM286Wv
        Y/YoHbUDgOnQHhnQp6PEZ16x1WvdgSr7Yd5hbhKv4sRDqQVFsKypfpnp6cLGp5jK90v5CRCCJk+jt
        I2OHeK/Pla/0Sr14yAhp2NaHP2j9TBhRiZGPvwD1Hx2UBKvt9L8bMWdgyDgRfdBKLlwgK3uHxTDjY
        bV8v2mCDAAWUQVDhYcJaOurIDfMb6wrOMJsg33nMXcpJbjypJ8gzZfhzP6FYAaHg==;
Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
        (Exim 4.96)
        (envelope-from <johannes@sipsolutions.net>)
        id 1olrti-00Cs7j-0i;
        Fri, 21 Oct 2022 15:17:14 +0200
Message-ID: <8343dfbd02b6206ce974d5280897d948892a86f9.camel@sipsolutions.net>
Subject: Re: [PATCH -next] rfkill: remove BUG_ON() in core.c
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Date:   Fri, 21 Oct 2022 15:17:13 +0200
In-Reply-To: <20221021130104.469966-1-yangyingliang@huawei.com>
References: <20221021130104.469966-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
X-malware-bazaar: not-scanned
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Fri, 2022-10-21 at 21:01 +0800, Yang Yingliang wrote:
> Replace BUG_ON() with pointer check to handle fault more gracefully.
>=20

That's basically (static) user errors though, so at least WARN_ON or
something?

johannes