Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <db62da89-8d43-df82-5c41-01fa40244d10@gmail.com>
Date:   Fri, 21 Oct 2022 20:36:12 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 3/5] wifi: rtl8xxxu: Recognise all possible chip cuts
Content-Language: en-US
To:     Ping-Ke Shih <pkshih@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     Jes Sorensen <Jes.Sorensen@gmail.com>
References: <2b29b6d9-c17e-76d6-c32f-630f24b407b7@gmail.com>
 <f7239792-028f-77dc-a86d-f89e3eeafa7d@gmail.com>
 <4294d0bed5e54862bb199bc2e8e4b6ae@realtek.com>
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <4294d0bed5e54862bb199bc2e8e4b6ae@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/10/2022 08:31, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> Sent: Monday, October 17, 2022 1:30 AM
>> To: linux-wireless@vger.kernel.org
>> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
>> Subject: [PATCH 3/5] wifi: rtl8xxxu: Recognise all possible chip cuts
>>
>> The chip cut, also known as the chip version, is a letter from A (0)
>> to P (15). Recognise them all instead of printing "unknown" when it's
>> greater than E.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> ---
>>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 27 +++++--------------
>>  1 file changed, 6 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> index 2efc99896b96..a8914650815e 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> @@ -1573,31 +1573,16 @@ rtl8xxxu_set_spec_sifs(struct rtl8xxxu_priv *priv, u16 cck, u16 ofdm)
>>
>>  static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv)
>>  {
>> +	static const char cuts[16] = "ABCDEFGHIJKLMNOP";
>>  	struct device *dev = &priv->udev->dev;
>> -	char *cut;
>> +	char cut = '?';
>>
>> -	switch (priv->chip_cut) {
>> -	case 0:
>> -		cut = "A";
>> -		break;
>> -	case 1:
>> -		cut = "B";
>> -		break;
>> -	case 2:
>> -		cut = "C";
>> -		break;
>> -	case 3:
>> -		cut = "D";
>> -		break;
>> -	case 4:
>> -		cut = "E";
>> -		break;
>> -	default:
>> -		cut = "unknown";
>> -	}
>> +	/* Currently always true: chip_cut is 4 bits. */
>> +	if (priv->chip_cut <= 15)
>> +		cut = cuts[priv->chip_cut];
> 
> How about?
> 
>    cut = 'A' + priv->chip_cut;
> 
That works too.