Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next] rfkill: replace BUG_ON() with WARN_ON() in core.c
To:     Leon Romanovsky <leon@kernel.org>
CC:     <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <johannes@sipsolutions.net>
References: <20221021135738.524370-1-yangyingliang@huawei.com>
 <Y1T4aWIbueaf4jYM@unreal>
From:   Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <ab635939-6763-42c1-0410-79e6c65b4568@huawei.com>
Date:   Mon, 24 Oct 2022 09:58:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <Y1T4aWIbueaf4jYM@unreal>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2022/10/23 16:16, Leon Romanovsky wrote:
> On Fri, Oct 21, 2022 at 09:57:38PM +0800, Yang Yingliang wrote:
>> Replace BUG_ON() with WARN_ON() to handle fault more gracefully.
>>
>> Suggested-by: Johannes Berg <johannes@sipsolutions.net>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>>   net/rfkill/core.c | 25 ++++++++++++++++---------
>>   1 file changed, 16 insertions(+), 9 deletions(-)
> Please add changelog and version numbers when you set your series.
>
> The same comment as https://lore.kernel.org/all/Y1T3a1y/pWdbt2ow@unreal
The link is unreachable.
> or you should delete BUG_ONs completely or simply replace them with WARN_ONs.
>
> There is no need in all these if (...).
If remove BUG_ONs or not use if (...), it may lead null-ptr-deref, it's 
same as
using BUG_ON(), which leads system crash.

Thanks,
Yang
>
> Thanks
> .