Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 11:32:51 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        johannes@sipsolutions.net
Subject: Re: [PATCH -next] rfkill: replace BUG_ON() with WARN_ON() in core.c
Message-ID: <Y1ZNs3w1ymYbjM9f@unreal>
References: <20221021135738.524370-1-yangyingliang@huawei.com>
 <Y1T4aWIbueaf4jYM@unreal>
 <ab635939-6763-42c1-0410-79e6c65b4568@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ab635939-6763-42c1-0410-79e6c65b4568@huawei.com>
Precedence: bulk

On Mon, Oct 24, 2022 at 09:58:59AM +0800, Yang Yingliang wrote:
> 
> On 2022/10/23 16:16, Leon Romanovsky wrote:
> > On Fri, Oct 21, 2022 at 09:57:38PM +0800, Yang Yingliang wrote:
> > > Replace BUG_ON() with WARN_ON() to handle fault more gracefully.
> > > 
> > > Suggested-by: Johannes Berg <johannes@sipsolutions.net>
> > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > > ---
> > >   net/rfkill/core.c | 25 ++++++++++++++++---------
> > >   1 file changed, 16 insertions(+), 9 deletions(-)
> > Please add changelog and version numbers when you set your series.
> > 
> > The same comment as https://lore.kernel.org/all/Y1T3a1y/pWdbt2ow@unreal
> The link is unreachable.

Try this https://lore.kernel.org/netdev/Y1T3a1y%2FpWdbt2ow@unreal/

> > or you should delete BUG_ONs completely or simply replace them with WARN_ONs.
> > 
> > There is no need in all these if (...).
> If remove BUG_ONs or not use if (...), it may lead null-ptr-deref, it's same
> as
> using BUG_ON(), which leads system crash.

May or will? Do you have crash report in hand?

This is rfkill API and an expectation is to have valid struct rfkill *rfkill.
Callers shouldn't call to these API functions if they know what rfkill is NULL.

Thanks

> 
> Thanks,
> Yang
> > 
> > Thanks
> > .