Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 21:00:31 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Chen, Rong A" <rong.a.chen@intel.com>
Cc:     kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Gregory Greenman <gregory.greenman@intel.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [kbuild-all] Re: include/trace/trace_events.h:261:16: error:
 function 'trace_event_get_offsets_iwlwifi_dbg' might be a candidate for
 'gnu_printf' format attribute
Message-ID: <20221024210031.3747fe18@gandalf.local.home>
In-Reply-To: <b612432e-7f21-4c79-5553-35ad7bdc6fd2@intel.com>
References: <202210212134.QTpb11ug-lkp@intel.com>
        <20221021101026.1708a426@gandalf.local.home>
        <ed665ca3-fa87-fee6-7284-9aed257264e4@intel.com>
        <20221024103524.43e13ab3@gandalf.local.home>
        <b612432e-7f21-4c79-5553-35ad7bdc6fd2@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 25 Oct 2022 08:49:41 +0800
"Chen, Rong A" <rong.a.chen@intel.com> wrote:

> > For any build that fails on warnings, that specific warning needs to be
> > silenced.
> > 
> > I mean, "-Werror=suggest-attribute=format", really?  
> 
> yes, it's compiled with -Werror if using 'W=1' option:
> 
>  >>>>>> include/trace/trace_events.h:261:16: error: function   
> 'trace_event_get_offsets_iwlwifi_dbg' might be a candidate for 
> 'gnu_printf' format attribute [-Werror=suggest-attribute=format]

Is there a way we can silent this particular error when W=1?

Ooh! Doing a search of this I found:

include/trace/events/qla.h:#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"

Perhaps I should just make that part of trace_events.h ?

-- Steve

(untested)

diff --git a/include/trace/trace_events.h b/include/trace/trace_events.h
index c2f9cabf154d..63db95559647 100644
--- a/include/trace/trace_events.h
+++ b/include/trace/trace_events.h
@@ -18,6 +18,11 @@
  * in the structure.
  */
 
+#pragma GCC diagnostic push
+#ifndef __clang__
+#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
+#endif
+
 #include <linux/trace_events.h>
 
 #ifndef TRACE_SYSTEM_VAR
@@ -467,3 +472,5 @@ static struct trace_event_call __used					\
 __section("_ftrace_events") *__event_##call = &event_##call
 
 #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
+
+#pragma GCC diagnostic pop