Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 15:34:21 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        gregkh@linuxfoundation.org, kvalo@kernel.org,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: remove bogus ssid character sign
 test
Message-ID: <Y1fXzQIz7nta7aE8@kadam>
References: <Y1e+SmS3O2ZaPVoe@kroah.com>
 <20221025122150.583617-1-Jason@zx2c4.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221025122150.583617-1-Jason@zx2c4.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C9Ebnp3qcF7g1CaU8GaRSLzdBW+Zb/vDz+mIUUjtc990urEvpoIwJ3LGRvI4?=
 =?us-ascii?Q?SSS3BUMe0YfYpzRVPTEraie4KpPCg/Iys6c8VOi5Qnoon2pIxLRs/34CzSEa?=
 =?us-ascii?Q?mdwGa5uv8VduqRjI8I8bV1GOgMXeV8M7Z1C+PLhf6hOFvt1GncBkO8S2OEyD?=
 =?us-ascii?Q?cQbe7ubA5GQk34pmCBwf9XffTalD6kKH6VTqQ/NM2WZsuwUj0fkjwxk6S8l/?=
 =?us-ascii?Q?WpQt8JiFdyeDKQXVXlhoq98cCjxr1An7AWi0IZ2MYTrHxL2P0LxADyaxXi3a?=
 =?us-ascii?Q?s9RTJ+L1eQWn3keSBQX90eDXo2A4rAPPSA0G/Q2Fz8FP3w6IMO2QMWBB2I5C?=
 =?us-ascii?Q?hlnjll/ClwjllNNgmofIOL1MZYLX3HQtVNkl0BhpIcl8yW0ZGziJaSyjM2pP?=
 =?us-ascii?Q?KtdTtbLdKyH1yYRWh6qt5ryCacNei9B+HCz5JK1kwgOYn/LFn5k3+BQ+gmkt?=
 =?us-ascii?Q?Z8Aw/HUv/Iac2YF1yQDlgEF1arpVovZ+keXukYzKtOHda25If/wzXoLcPAdz?=
 =?us-ascii?Q?uhZW/p5QIqXVd+ezSbO1IKZT56YAj1DkFyDYP+Lms+cgnY1SYKGN3mHAJHE5?=
 =?us-ascii?Q?caWnpBqziS4lT+yq523BtSZxC70YGRnboEF4T02RWPCnG0Pmp74c/lrKs8wx?=
 =?us-ascii?Q?6pHxW6bn6a7zGPYTTee/WqQQjlEs7JpmZcPCuWHlThMIewrDPs5DEdHWcKW1?=
 =?us-ascii?Q?OR4YMNJ42UiaAdEFPoDsz/nfEHZ9bWGl9jk+3gqwCHoaoQhipnNQEMdD8hHm?=
 =?us-ascii?Q?HuRebtQhZRSpfdDmAWfNSSfs7FJCoGcLECo5Xo329OapY6T65sXgRZ6fhMjb?=
 =?us-ascii?Q?dCCQX689cQcI+Ii60SMIzlOJVQp7AkxO7PnG/nZqV25VE/aTBm4k3qbqROQn?=
 =?us-ascii?Q?tND7Uww57KhJCL20yojm6dU89T2oljPzC7OEQeBtV1s6/nOdICbP/191GbO1?=
 =?us-ascii?Q?xwRf5kQmYTLc+SvV/epNkJw/q2NK/5en2M5/Adw9jDFGM7DhwfvJReCwmE5a?=
 =?us-ascii?Q?ELLKfvxcg+lyD0AY8io/ZE89HkcOBT3PdfgpcB4RjCLkVqBS4rHGSgKyxD7d?=
 =?us-ascii?Q?2Fi0MUTD6Wbp5h49Sv+6gfm7dcy0gNM8SAmIKQRjDpHAQSqQiTUfu8jbFdnx?=
 =?us-ascii?Q?fg/xUL/73z9Me47g6/OXhjg99FKXFIi56qlfX9ZnKwHtrerGHmHK1nltQ0RT?=
 =?us-ascii?Q?cL2YgwDWZslcSk1CqVA/WPZI18luCJuVLozPEFWyZcmXD1Hy8zs+nLtvnTYN?=
 =?us-ascii?Q?D549Fkn+NjUZSriIsgHaTXqMmAb5ajD/kaeg6oax+i3t40Rq89dxRuNMm0sa?=
 =?us-ascii?Q?eTCxXMwTNUC3w+3NZ+h02plGtSOuo4pv5qS8sslqnHeRUEXsmo6gsaux5IJe?=
 =?us-ascii?Q?GW8fPxM1Zj0Ql5gQ4mMJQU4gsFbarqwSxUlThno0dUvpVCwKC+nNvG6gHpGL?=
 =?us-ascii?Q?dZxSVpZPBrLFNvz5XV4jQBN3YDAP3r0ZicRjQi7uU859MOFfUB31f9HGnd0Q?=
 =?us-ascii?Q?uU8V8eVPcPrJT4GFyxBOcTmLyOypd5m5rGeG+jBEtMaJcHEM15TCqvN2EUsM?=
 =?us-ascii?Q?GkwnyzyTFGo516c2sNLGqZMNe8sxUmcEikIizBjFghwxuobMYLqi5Jq0SZwk?=
 =?us-ascii?Q?Jg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57501ffd-5421-4354-8474-08dab6854574
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 12:34:33.9765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OfBI+tlbwcX/Zk0KmeqLJomnIHw/2NaYyNGuiADn/BZBo4TVIaeGchixyAGDM30w4X0tt3ygGOsc2e7SMRdzYpKLM+GJwAl0woL//hzGR64=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5029
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-25_06,2022-10-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210250072
X-Proofpoint-GUID: 4U1mmXViZWabIupgSNu_NYSGHlE_d3aw
X-Proofpoint-ORIG-GUID: 4U1mmXViZWabIupgSNu_NYSGHlE_d3aw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Oct 25, 2022 at 02:21:50PM +0200, Jason A. Donenfeld wrote:
> This error triggers on some architectures with unsigned `char` types:
> 
> drivers/staging/rtl8192e/rtllib_softmac_wx.c:459 rtllib_wx_set_essid() warn: impossible condition '(extra[i] < 0) => (0-255 < 0)'
> 
> But actually, the entire test is bogus, as ssids don't have any sign
> validity rules like that. So just remove this check look all together.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-staging@lists.linux.dev
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> Changes v1->v2:
> - Remove ssid sign test entirely rather than casting to `s8 *`.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter