Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        "Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>,
        <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list.pdl@broadcom.com>,
        <brcm80211-dev-list@cypress.com>
Subject: Re: [PATCH] brcm80211: brcmsmac: Drop BMCMA consistency check
References: <20221024124002.10120-1-linus.walleij@linaro.org>
        <1840a6374e8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Date:   Tue, 25 Oct 2022 23:09:23 +0300
In-Reply-To: <1840a6374e8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
        (Arend Van Spriel's message of "Mon, 24 Oct 2022 16:26:42 +0200")
Message-ID: <87wn8ny8b0.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Arend Van Spriel <arend.vanspriel@broadcom.com> writes:

> On October 24, 2022 2:40:08 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> The driver looks up the BCMA parent GPIO driver and checks that
>> this succeeds, but then it goes on to use the deprecated GPIO
>> call gpio_is_valid() to check the consistency of the .base
>> member of the BCMA GPIO struct. Surely this belongs in the
>> BCMA driver: we cannot have all drivers performing cosistency
>
> Should be: consistency
>
>>
>> checks on the internals of things they are passed.
>
> Apart from the typo in the subject and missing wifi: prefix (replace
> 'brcm80211' by 'wifi')...

I can fix those.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches