Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221024124002.10120-1-linus.walleij@linaro.org>
 <1840a6374e8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <87wn8ny8b0.fsf@kernel.org>
In-Reply-To: <87wn8ny8b0.fsf@kernel.org>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 26 Oct 2022 09:52:42 +0200
Message-ID: <CACRpkdbdziYcMpBij22ryTvAX776ShXFkzD1_WfXq5fUiwVSVQ@mail.gmail.com>
Subject: Re: [PATCH] brcm80211: brcmsmac: Drop BMCMA consistency check
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Arend Van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 25, 2022 at 10:09 PM Kalle Valo <kvalo@kernel.org> wrote:

> Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
>
> > On October 24, 2022 2:40:08 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> >> The driver looks up the BCMA parent GPIO driver and checks that
> >> this succeeds, but then it goes on to use the deprecated GPIO
> >> call gpio_is_valid() to check the consistency of the .base
> >> member of the BCMA GPIO struct. Surely this belongs in the
> >> BCMA driver: we cannot have all drivers performing cosistency
> >
> > Should be: consistency
> >
> >>
> >> checks on the internals of things they are passed.
> >
> > Apart from the typo in the subject and missing wifi: prefix (replace
> > 'brcm80211' by 'wifi')...
>
> I can fix those.

I am sending a combined patch with this and the other bcma patch
because they happen to depend on each other. Dunno how to tag
a patch that affects bcma and brcn80211 at the same time so you
will probably have to edit it anyway.

Yours,
Linus Walleij