Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ae140509-e105-42d0-f782-8abe1100b981@gmail.com>
Date:   Wed, 26 Oct 2022 15:06:11 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2 2/5] wifi: rtl8xxxu: Fix the CCK RSSI calculation
To:     Ping-Ke Shih <pkshih@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     Jes Sorensen <Jes.Sorensen@gmail.com>
References: <1edda764-94ca-2123-0ba6-6b04a1b01709@gmail.com>
 <25b7381d-178c-d909-015e-1acf7698ec13@gmail.com>
 <7040619d7d5c4b198b320812093d33f9@realtek.com>
Content-Language: en-US
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <7040619d7d5c4b198b320812093d33f9@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/10/2022 06:46, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> Sent: Tuesday, October 25, 2022 4:55 AM
>> To: linux-wireless@vger.kernel.org
>> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
>> Subject: [PATCH v2 2/5] wifi: rtl8xxxu: Fix the CCK RSSI calculation
>>
>> The CCK RSSI calculation is incorrect for the RTL8723BU, RTL8192EU,
>> and RTL8188FU. Add new functions for these chips with code copied from
>> their vendor drivers. Use the old code only for the RTL8723AU and
>> RTL8192CU.
>>
>> I didn't notice any difference in the reported signal strength with my
>> RTL8188FU, but I didn't look very hard either.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> ---
>> v2:
>>  - No change.
>> ---
>>  .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h  |  3 ++
>>  .../realtek/rtl8xxxu/rtl8xxxu_8188f.c         | 32 ++++++++++++++++
>>  .../realtek/rtl8xxxu/rtl8xxxu_8192c.c         |  1 +
>>  .../realtek/rtl8xxxu/rtl8xxxu_8192e.c         | 23 +++++++++++
>>  .../realtek/rtl8xxxu/rtl8xxxu_8723a.c         | 23 +++++++++++
>>  .../realtek/rtl8xxxu/rtl8xxxu_8723b.c         | 29 ++++++++++++++
>>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 38 ++++++++++++-------
>>  7 files changed, 135 insertions(+), 14 deletions(-)
>>
> 
> [...]
> 
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> index 86a3457fd951..7023f6accda7 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> @@ -4325,6 +4325,29 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw)
>>  		val32 &= 0xfff00fff;
>>  		val32 |= 0x0007e000;
>>  		rtl8xxxu_write32(priv, REG_AFE_MISC, val32);
>> +
>> +		/*
>> +		 * 0x824[9] = 0x82C[9] = 0xA80[7] those registers setting
>> +		 * should be equal or CCK RSSI report may be incorrect
>> +		 */
>> +		val32 = rtl8xxxu_read32(priv, REG_FPGA0_XA_HSSI_PARM2);
>> +		priv->cck_agc_report_type = val32 & FPGA0_HSSI_PARM2_CCK_HIGH_PWR;
>> +
>> +		val32 = rtl8xxxu_read32(priv, REG_FPGA0_XB_HSSI_PARM2);
>> +		if (priv->cck_agc_report_type != (bool)(val32 & FPGA0_HSSI_PARM2_CCK_HIGH_PWR)) {
>> +			if (priv->cck_agc_report_type)
>> +				val32 |= FPGA0_HSSI_PARM2_CCK_HIGH_PWR;
>> +			else
>> +				val32 &= ~FPGA0_HSSI_PARM2_CCK_HIGH_PWR;
>> +			rtl8xxxu_write32(priv, REG_FPGA0_XB_HSSI_PARM2, val32);
>> +		}
>> +
>> +		val32 = rtl8xxxu_read32(priv, 0xa80);
>> +		if (priv->cck_agc_report_type)
>> +			val32 |= BIT(7);
>> +		else
>> +			val32 &= ~BIT(7);
> 
> We can give a name to 0xA80[7]: 
> 
> #define REG_AGC_RPT 0x0a80
> #define AGC_RTP_CCK BIT(7)
> 
> 
Thanks, I'll add it.