Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     "Joseph S. Barrera III" <joebar@chromium.org>
Cc:     Rahul Bhattacharjee <quic_rbhattac@quicinc.com>,
        ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization
References: <20221021090126.28626-1-quic_rbhattac@quicinc.com>
        <11e005c2-2363-d63f-9f3f-3ca811737231@chromium.org>
Date:   Fri, 28 Oct 2022 13:44:09 +0300
In-Reply-To: <11e005c2-2363-d63f-9f3f-3ca811737231@chromium.org> (Joseph S.
        Barrera, III's message of "Wed, 26 Oct 2022 12:46:56 -0700")
Message-ID: <87pmecgrd2.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

"Joseph S. Barrera III" <joebar@chromium.org> writes:

> On 10/21/22 2:01 AM, Rahul Bhattacharjee wrote:
>
>>   	},
>> +	{/* end of list */}
>>   };
>
> Do you want to add a comma after that last list element?

I can add that in the pending branch.

>
> Actually, I normally see the last list element simply being
>
>> +	{},
>
> ... with no comment necessary.

I would prefer to have a comment to make it more visible that an empty
element is needed at the end, but I would add that outside of braces?

/* end of list */
{},

Thoughts? I can change this in the pending branch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches