Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22be4248-9c5e-e6d3-5e49-e0d87ec52e4b@chromium.org>
Date:   Fri, 28 Oct 2022 06:25:49 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure
 initialization
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Rahul Bhattacharjee <quic_rbhattac@quicinc.com>,
        ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
References: <20221021090126.28626-1-quic_rbhattac@quicinc.com>
 <11e005c2-2363-d63f-9f3f-3ca811737231@chromium.org>
 <87pmecgrd2.fsf@kernel.org>
Content-Language: en-US
From:   "Joseph S. Barrera III" <joebar@chromium.org>
In-Reply-To: <87pmecgrd2.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/28/22 3:44 AM, Kalle Valo wrote:
> "Joseph S. Barrera III" <joebar@chromium.org> writes:
>> Do you want to add a comma after that last list element?
> 
> I can add that in the pending branch.

I think that would be good.

> I would prefer to have a comment to make it more visible that an empty
> element is needed at the end, but I would add that outside of braces?
> 
> /* end of list */
> {},

Ending a list with {}, is such a common idiom that adding a comment
is kind of just noise. And if you look at other such instances of
ending with an empty element, you'll find no comment, just the {},.
When making changes I prefer to stick to the existing coding style
as much as possible, so in this case I would definitely omit the 
comment. But if you do feel like you need to add a comment, I would
keep it on the same line as the empty element, probably like

   {}, // end of list