Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02494022-6f02-22ba-eb9e-f57384c9238d@wetzel-home.de>
Date:   Tue, 1 Nov 2022 09:18:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] wifi: mac80211: convert PS buffering into iTXQ
To:     linux-wireless@vger.kernel.org
Cc:     Johannes Berg <johannes@sipsolutions.net>
References: <20221031211815.6666-1-alexander@wetzel-home.de>
Content-Language: en-US
From:   Alexander Wetzel <alexander@wetzel-home.de>
In-Reply-To: <20221031211815.6666-1-alexander@wetzel-home.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


> @@ -3773,6 +3577,13 @@ struct sk_buff *ieee80211_tx_dequeue(struct ieee80211_hw *hw,
>   			ieee80211_free_txskb(&local->hw, skb);
>   			goto begin;
>   		}
> +	} else if (vif->txq == txq &&
> +		   vif->type == NL80211_IFTYPE_AP &&
> +		   atomic_read(&tx.sdata->bss->ps.num_sta_ps)) {
> +		info->flags |= IEEE80211_TX_CTL_SEND_AFTER_DTIM;
> +
> +		if (ieee80211_hw_check(&tx.local->hw, QUEUE_CONTROL))
> +			info->hw_queue = tx.sdata->vif.cab_queue;

I forgot to drop the two lines above.

vif.cab_queue is also set in ieee80211_get_txq(), making these lines 
redundant. (As standalone they would be wrong and not always setting the 
flag when needed.)

Since I'm sure there will be more issues I won't submit a new patch 
immediately.

Alexander