Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     "Youghandhar Chintala \(Temp\)" <quic_youghand@quicinc.com>
Cc:     Jeff Johnson <quic_jjohnson@quicinc.com>,
        <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath10k: Add WLAN firmware image version info into smem
References: <20221026102257.19919-1-quic_youghand@quicinc.com>
        <b55ef95f-f400-9ef6-a427-525ae529d673@quicinc.com>
        <fd45187c-739c-cd5d-4d4b-ae6abad03a94@quicinc.com>
Date:   Tue, 01 Nov 2022 11:01:33 +0200
In-Reply-To: <fd45187c-739c-cd5d-4d4b-ae6abad03a94@quicinc.com> (Youghandhar
        Chintala's message of "Mon, 31 Oct 2022 12:24:43 +0530")
Message-ID: <877d0fgiaa.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

(fixing quotation)

"Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com> writes:

> On 10/28/2022 12:19 AM, Jeff Johnson wrote:
>
>> On 10/26/2022 3:22 AM, Youghandhar Chintala wrote:

>>> =C2=A0 +static void ath10k_qmi_add_wlan_ver_smem(struct ath10k *ar, char
>>> *fw_build_id)
>>
>> const char *fw_build_id?
>>
>>> +{
>>> +=C2=A0=C2=A0=C2=A0 u8 *smem_table_ptr;
>>> +=C2=A0=C2=A0=C2=A0 size_t smem_block_size;
>>> +=C2=A0=C2=A0=C2=A0 const u32 version_string_size =3D 128;
>>
>> should you s/128/MAX_BUILD_ID_LEN/ since that is what is used to
>> size qmi->fw_build_id?
>>
>> or alternately have the caller pass fw_build_id length as a separate
>> param?
>
> Sure Jeff. Will address it in next version of patch.

BTW Youghandhar, your quotes were broken in this mail so your reply was
difficult to find. See here:

https://patchwork.kernel.org/project/linux-wireless/patch/20221026102257.19=
919-1-quic_youghand@quicinc.com/

If you are using Outlook, I recommend switching to an application which
respects standards more :) For example, some people seem to be happy
with Thunderbird.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes