Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc:     "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: Re: [PATCH v3 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info
References: <d1cfc9ef-dfc1-b3dc-c471-fe18aee8962e@gmail.com>
        <f5ceeb63-bfd2-0fe5-c88b-2bc4c9c7c46a@gmail.com>
Date:   Tue, 01 Nov 2022 13:11:50 +0200
In-Reply-To: <f5ceeb63-bfd2-0fe5-c88b-2bc4c9c7c46a@gmail.com> (Bitterblue
        Smith's message of "Fri, 28 Oct 2022 19:40:29 +0300")
Message-ID: <87iljzudxl.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:

> Replace two instances of bare pr_info with dev_info.
>
> Also make their messages a little more informative.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

[...]

> @@ -5420,7 +5421,8 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
>  			rtl8xxxu_queue_rx_urb(priv, rx_urb);
>  			break;
>  		default:
> -			pr_info("failed to requeue urb %i\n", ret);
> +			dev_info(&priv->udev->dev,
> +				 "failed to requeue urb with error %i\n", ret);

Should this be dev_warn()? It looks like a warning.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches