Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f0fcd38a-83f6-e22a-b715-facf61d67b7d@gmail.com>
Date:   Tue, 1 Nov 2022 19:49:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v3 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info
To:     Kalle Valo <kvalo@kernel.org>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Jes Sorensen <Jes.Sorensen@gmail.com>
References: <d1cfc9ef-dfc1-b3dc-c471-fe18aee8962e@gmail.com>
 <f5ceeb63-bfd2-0fe5-c88b-2bc4c9c7c46a@gmail.com> <87iljzudxl.fsf@kernel.org>
Content-Language: en-US
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <87iljzudxl.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/11/2022 13:11, Kalle Valo wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
> 
>> Replace two instances of bare pr_info with dev_info.
>>
>> Also make their messages a little more informative.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> 
> [...]
> 
>> @@ -5420,7 +5421,8 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
>>  			rtl8xxxu_queue_rx_urb(priv, rx_urb);
>>  			break;
>>  		default:
>> -			pr_info("failed to requeue urb %i\n", ret);
>> +			dev_info(&priv->udev->dev,
>> +				 "failed to requeue urb with error %i\n", ret);
> 
> Should this be dev_warn()? It looks like a warning.
> 
Probably yes. I'll do that and also rebase everything.