Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp21199rwi; Wed, 2 Nov 2022 08:57:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7ceqo6tCtfj1yrAhU4nTxqE03USIDX3ejKepK/WrBFkJtHcZKfLkQsD44byllSUdQz8zlH X-Received: by 2002:a17:902:cec3:b0:187:12cc:d699 with SMTP id d3-20020a170902cec300b0018712ccd699mr20337821plg.83.1667404621299; Wed, 02 Nov 2022 08:57:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667404621; cv=none; d=google.com; s=arc-20160816; b=HwXsJ6ATbzZzX0e4rH2R/T+QWiYuuhkdqY1ZxWGxOzyz3Lza3ywA+V6RNWoKDZRyzR 4MrW3iZ3ODXpGEb9fGHYKxQEYNTBUPIWBE7iBu2b6fwR9ACN9z9J6gjP2T+Sk0ATdZMw s7yF/Q34h9T5jh/vF+h+Fwu3V5dGeqWqG+VP12fYhApuCMiLppH5h07yuKggxkRCg8LE IGVFpaUJUoM9XFiNsauMxBhsU8FpVCXmbiyAn6h6Zq85yjc6/1FpeTUjEYjt59Q3Ip2z o3EWhXATSrNBZBa38HjA+tnlMHiFaXRJAgfbt80d8jINSvpt4lpNqoO+Xqhw45SrciHz eOCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Pi3yyQZtEoxrit46NWk4z5OygJ4MH28mMJ6k1V20o1w=; b=tJQFoyHfE/RQl9YuYUzk3CwGr2u8KEo2b6HybjJ2eT92Zd+XggNwjsqQZiVk95eeex F8Qiqrcbu9GzyuCfN5UV5soUDUgOPl0qhqZhmEeWf3p3WIk7XaYcrNshNLnWfegFNnZj EY9tH8U0dRwy6lu50+04VEIVEJJLDHXcze1zyG3LS3JPb8dCjbGk+QK95UW3CPdkhExQ F7rFssyNYLNAfbQcY28rPfX4SN4AyB1Cnyc8TBDUK/TzXUWPX8Lq24Lu9WDnaexA5q59 FwRNwukB+ECRo3TWUJqJU+GSQoebwooD0rDOnFOeXnD2xohhUyX5bVgSZRYBgnlAo+QE F25A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CDDvlzIc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ct24-20020a056a000f9800b0056ce4cd9580si14893671pfb.73.2022.11.02.08.56.49; Wed, 02 Nov 2022 08:57:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CDDvlzIc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbiKBPx6 (ORCPT + 66 others); Wed, 2 Nov 2022 11:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230513AbiKBPxz (ORCPT ); Wed, 2 Nov 2022 11:53:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AD392BB32 for ; Wed, 2 Nov 2022 08:53:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC6D261A18 for ; Wed, 2 Nov 2022 15:53:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F62EC433D6; Wed, 2 Nov 2022 15:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667404432; bh=giDt3b+ZyHrsaDQ8U7LNdJ82qFVrIpbBLkCjORuwo3k=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=CDDvlzIcPhZS1ensHRxN66iZdb+Ik82yS3lEf86tw/uzWekYwdUxPMBOTL01iBt5v 31r2U4DyDGPWSqh3N4YUSPH9FgMBfmuWnmgID80NK/U5ptgTLr2PEYEfPWW5V9K8D8 8Y8wJu7XYs4o+aWLKJYTIOWRVz2hAKcX2oTKtPQo5ZxRVCy/tSqENiFTZds7qh+RhK 3SX1iZA7V/+F0mvN9r5XYpj/DwF2D/lk1HnSnCAqdvgD3RHMU/GGZVCmLw+bBSfeou yaL4oFfAlJ7/4HZB0wwwQmBth78vaG+1UZs5or7VtSnnaTfWjkwFCwQ1dAMTUdePy5 tPWlGaLsopWLg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization From: Kalle Valo In-Reply-To: <20221021090126.28626-1-quic_rbhattac@quicinc.com> References: <20221021090126.28626-1-quic_rbhattac@quicinc.com> To: Rahul Bhattacharjee Cc: , , Rahul Bhattacharjee User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166740442931.20386.6032191659181258004.kvalo@kernel.org> Date: Wed, 2 Nov 2022 15:53:51 +0000 (UTC) X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Rahul Bhattacharjee wrote: > qmi_msg_handler is required to be null terminated by QMI module. > There might be a case where a handler for a msg id is not present in the > handlers array which can lead to infinite loop while searching the handler > and therefore out of bound access in qmi_invoke_handler(). > Hence update the initialization in qmi_msg_handler data structure. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Rahul Bhattacharjee > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ed3725e15a15 wifi: ath11k: Fix qmi_msg_handler data structure initialization -- https://patchwork.kernel.org/project/linux-wireless/patch/20221021090126.28626-1-quic_rbhattac@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches