Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Nov 2022 23:37:00 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Bo Jiao <Bo.Jiao@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Peter Chiu <chui-hao.chiu@mediatek.com>
Subject: Re: [PATCH 01/10] wifi: mt76: extend aggr_stats for tri-band support
Message-ID: <Y2LxDLqPa45Xbe9n@lore-desk>
References: <20221031164000.17063-1-shayne.chen@mediatek.com>
 <20221031164000.17063-2-shayne.chen@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="8OepT4zXwtk9Efj7"
Content-Disposition: inline
In-Reply-To: <20221031164000.17063-2-shayne.chen@mediatek.com>
Precedence: bulk


--8OepT4zXwtk9Efj7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Nov 01, Shayne Chen wrote:
> Make band2 able to report aggregation stats.
> This is a preliminary patch to add mt7996 chipset support.
>=20
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wire=
less/mediatek/mt76/mt76.h
> index f9bdf16fc6c4..42847b327cb0 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> @@ -781,7 +781,7 @@ struct mt76_dev {
> =20
>  	u32 rev;
> =20
> -	u32 aggr_stats[32];
> +	u32 aggr_stats[16 * __MT_MAX_BAND];

I think this patch will break mt7915 and mt7921 drivers.

Regards,
Lorenzo

> =20
>  	struct tasklet_struct pre_tbtt_tasklet;
>  	int beacon_int;
> --=20
> 2.25.1
>=20

--8OepT4zXwtk9Efj7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCY2LxDAAKCRA6cBh0uS2t
rEB8AP9Dm5/DXpvQLm3l29yvDhyBM5gPC9tAq05+24dkf8At3QD9HVpnd8JIW8ZR
E4bSiHw7IUPp15+Bp53TQvck0WVT0ww=
=vlXf
-----END PGP SIGNATURE-----

--8OepT4zXwtk9Efj7--