Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b1d79689-da3e-403b-647a-679fe7225a20@quicinc.com>
Date:   Thu, 3 Nov 2022 13:57:41 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.2
Subject: Re: [PATCH] wifi: ath11k: Trigger sta disconnect on hardware restart
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
CC:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_mpubbise@quicinc.com>
References: <20221102061423.1032-1-quic_youghand@quicinc.com>
 <166740851734.26077.10462970085577578665.kvalo@kernel.org>
From:   "Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com>
In-Reply-To: <166740851734.26077.10462970085577578665.kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/2/2022 10:32 PM, Kalle Valo wrote:
> Youghandhar Chintala <quic_youghand@quicinc.com> wrote:
>
>> Currently after the hardware restart triggered from the driver, the
>> station interface connection remains intact, since a disconnect trigger
>> is not sent to userspace. This can lead to a problem in targets where
>> the wifi mac sequence is added by the firmware.
>>
>> After the target restart, its wifi mac sequence number gets reset to
>> zero. Hence AP to which our device is connected will receive frames with
>> a  wifi mac sequence number jump to the past, thereby resulting in the
>> AP dropping all these frames, until the frame arrives with a wifi mac
>> sequence number which AP was expecting.
>>
>> To avoid such frame drops, its better to trigger a station disconnect
>> upon target hardware restart which can be done with API
>> ieee80211_reconfig_disconnect exposed to mac80211.
>>
>> The other targets are not affected by this change, since the hardware
>> params flag is not set.
>>
>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
>>
>> Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com>
> Fails to compile:
>
> In file included from ./include/linux/wait.h:7,
>                   from ./include/linux/wait_bit.h:8,
>                   from ./include/linux/fs.h:6,
>                   from ./include/linux/highmem.h:5,
>                   from ./include/linux/bvec.h:10,
>                   from ./include/linux/skbuff.h:17,
>                   from ./include/linux/if_ether.h:19,
>                   from ./include/net/mac80211.h:18,
>                   from drivers/net/wireless/ath/ath11k/mac.c:7:
> drivers/net/wireless/ath/ath11k/mac.c: In function 'ath11k_mac_op_reconfig_complete':
> drivers/net/wireless/ath/ath11k/mac.c:8049:45: error: 'arvif' undeclared (first use in this function)
>   8049 |                         list_for_each_entry(arvif, &ar->arvifs, list) {
>        |                                             ^~~~~
> ./include/linux/list.h:674:14: note: in definition of macro 'list_for_each_entry'
>    674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>        |              ^~~
> drivers/net/wireless/ath/ath11k/mac.c:8049:45: note: each undeclared identifier is reported only once for each function it appears in
>   8049 |                         list_for_each_entry(arvif, &ar->arvifs, list) {
>        |                                             ^~~~~
> ./include/linux/list.h:674:14: note: in definition of macro 'list_for_each_entry'
>    674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>        |              ^~~
> In file included from ./include/linux/bits.h:22,
>                   from ./include/linux/ratelimit_types.h:5,
>                   from ./include/linux/printk.h:9,
>                   from ./include/asm-generic/bug.h:22,
>                   from ./arch/x86/include/asm/bug.h:87,
>                   from ./include/linux/bug.h:5,
>                   from ./include/net/mac80211.h:16:
> ././include/linux/compiler_types.h:298:27: error: expression in static assertion is not an integer
>    298 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
>        |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>     78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>        |                                                        ^~~~
> ./include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>     19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>        |         ^~~~~~~~~~~~~
> ./include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>     19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>        |                       ^~~~~~~~~~~
> ./include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>    520 |         container_of(ptr, type, member)
>        |         ^~~~~~~~~~~~
> ./include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
>    531 |         list_entry((ptr)->next, type, member)
>        |         ^~~~~~~~~~
> ./include/linux/list.h:674:20: note: in expansion of macro 'list_first_entry'
>    674 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
>        |                    ^~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mac.c:8049:25: note: in expansion of macro 'list_for_each_entry'
>   8049 |                         list_for_each_entry(arvif, &ar->arvifs, list) {
>        |                         ^~~~~~~~~~~~~~~~~~~
> ././include/linux/compiler_types.h:298:27: error: expression in static assertion is not an integer
>    298 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
>        |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
>     78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>        |                                                        ^~~~
> ./include/linux/container_of.h:19:9: note: in expansion of macro 'static_assert'
>     19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>        |         ^~~~~~~~~~~~~
> ./include/linux/container_of.h:19:23: note: in expansion of macro '__same_type'
>     19 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>        |                       ^~~~~~~~~~~
> ./include/linux/list.h:520:9: note: in expansion of macro 'container_of'
>    520 |         container_of(ptr, type, member)
>        |         ^~~~~~~~~~~~
> ./include/linux/list.h:564:9: note: in expansion of macro 'list_entry'
>    564 |         list_entry((pos)->member.next, typeof(*(pos)), member)
>        |         ^~~~~~~~~~
> ./include/linux/list.h:676:20: note: in expansion of macro 'list_next_entry'
>    676 |              pos = list_next_entry(pos, member))
>        |                    ^~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mac.c:8049:25: note: in expansion of macro 'list_for_each_entry'
>   8049 |                         list_for_each_entry(arvif, &ar->arvifs, list) {
>        |                         ^~~~~~~~~~~~~~~~~~~
> make[6]: *** [scripts/Makefile.build:250: drivers/net/wireless/ath/ath11k/mac.o] Error 1
> make[5]: *** [scripts/Makefile.build:500: drivers/net/wireless/ath/ath11k] Error 2
> make[4]: *** [scripts/Makefile.build:500: drivers/net/wireless/ath] Error 2
> make[3]: *** [scripts/Makefile.build:500: drivers/net/wireless] Error 2
> make[2]: *** [scripts/Makefile.build:500: drivers/net] Error 2
> make[1]: *** [scripts/Makefile.build:500: drivers] Error 2
> make: *** [Makefile:1992: .] Error 2
>
> Patch set to Changes Requested.


Apologies Kalle. Will post next version of patch with fix.

Regards,

Youghandhar