Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a3ef782d-9c85-d752-52b5-589d5e1f1bd5@denx.de>
Date:   Fri, 4 Nov 2022 17:09:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via
 control port
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
Cc:     Amitkumar Karwar <amit.karwar@redpinesignals.com>,
        Angus Ainslie <angus@akkea.ca>,
        Jakub Kicinski <kuba@kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Martin Fuzzey <martin.fuzzey@flowbird.group>,
        Martin Kepplinger <martink@posteo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
        Siva Rebbagondla <siva8118@gmail.com>, netdev@vger.kernel.org
References: <20221104155841.213387-1-marex@denx.de>
 <cf7da8e9a135fee1a9ac0e8f768a2a13bbba058d.camel@sipsolutions.net>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <cf7da8e9a135fee1a9ac0e8f768a2a13bbba058d.camel@sipsolutions.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/4/22 17:01, Johannes Berg wrote:
> On Fri, 2022-11-04 at 16:58 +0100, Marek Vasut wrote:
>>
>> Therefore, to fix this problem, inspect the ETH_P_802_3 frames in
>> the rsi_91x driver, check the ethertype of the encapsulated frame,
>> and in case it is ETH_P_PAE, transmit the frame via high-priority
>> queue just like other ETH_P_PAE frames.
> 
> This part seems wrong now.

OK

>> +bool rsi_is_tx_eapol(struct sk_buff *skb)
>> +{
>> +	return !!(IEEE80211_SKB_CB(skb)->control.flags &
>> +		  IEEE80211_TX_CTRL_PORT_CTRL_PROTO);
>> +}
> 
> For how trivial this is now, maybe make it an inline? Feels fairly
> pointless to have it as an out-of-line function to call in another file
> when it's a simple bit check.

In V2 it was suggested I deduplicate this into a separate function, 
since the test is done in multiple places. I would like to keep it 
deduplicated.

> You can also drop the !! since the return value is bool.

OK