Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f3b0adccfff86b687bf2e9fd3e3f9657444bfdf0.camel@sipsolutions.net>
Subject: Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent
 via control port
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Marek Vasut <marex@denx.de>, linux-wireless@vger.kernel.org
Cc:     Angus Ainslie <angus@akkea.ca>, Jakub Kicinski <kuba@kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Martin Fuzzey <martin.fuzzey@flowbird.group>,
        Martin Kepplinger <martink@posteo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
        Siva Rebbagondla <siva8118@gmail.com>, netdev@vger.kernel.org
Date:   Fri, 04 Nov 2022 17:25:09 +0100
In-Reply-To: <d6c8594159368034d47a169ccdd50bc65a1ad894.camel@sipsolutions.net>
References: <20221104155841.213387-1-marex@denx.de>
         <cf7da8e9a135fee1a9ac0e8f768a2a13bbba058d.camel@sipsolutions.net>
         <a3ef782d-9c85-d752-52b5-589d5e1f1bd5@denx.de>
         <d6c8594159368034d47a169ccdd50bc65a1ad894.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

(removing Amitkumar Karwar <amit.karwar@redpinesignals.com> as that
keeps bouncing)

On Fri, 2022-11-04 at 17:23 +0100, Johannes Berg wrote:
> On Fri, 2022-11-04 at 17:09 +0100, Marek Vasut wrote:
> >=20
> > In V2 it was suggested I deduplicate this into a separate function,=20
> > since the test is done in multiple places. I would like to keep it=20
> > deduplicated.
>=20
> Well, it's now a lot simpler, so one might argue that it's not needed.
>=20
> But anyway you're touching the hot-path of this driver, and making it an
> inline still keeps it de-duplicated, so not sure why you wouldn't just
> move the rsi_is_tx_eapol into the header file as static inline?
>=20

Though honestly, if we thought it was worth deduplicating a simple bit
check like that, we could define an inline helper in mac80211.h. I'm not
really convinced it is :)

But hey, that's not my driver, so ultimately I don't _really_ care so
much.

johannes