Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp1236908rwl; Fri, 4 Nov 2022 11:22:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6a1gaiMGjQeDxsuub92khs3yeRGn2wqGK/NxfJ1Y3byddrZAq6/CKrIdl8MFQKCUq9Xa3r X-Received: by 2002:a05:6402:1d4f:b0:461:d2ed:788c with SMTP id dz15-20020a0564021d4f00b00461d2ed788cmr37140299edb.418.1667586158056; Fri, 04 Nov 2022 11:22:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667586158; cv=none; d=google.com; s=arc-20160816; b=HqM0RZS63haIX1QvoBo7aTdo9xBi8WUXwJBG2cQel+u5HNO5isvxqVdxDrswtkTJQR xbh727XraZlxa/413mfFY3z3b4CXMte1VgmQXNnX/ZlVfaQCspAKMEw8kMWlXDpNSzA9 YC8Eup2nP4SoY6+KDydx5XYa4CWeIHF9YLMNlWdxpFPTAqWtQfexOeQ7dLTYJ1mTsK9I 0stTMLtFhzwV2W/acjSYdDW/ryLdsnaP4mtwjg32POzppStKHt3DpW0tg5oAOrkfljpO KFXXAM5kSurHDFREwt2hgx4/Gej+TKcqXGeJqRz62v+gn/VerJaA11XXr6M4DwXeEE+v jfbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Q9GarPgLivF/cbVnUOc8amI6hZVHYMYcm7aIwZBj2EE=; b=wdWmF6ztXm3XvCqAOaJ3xT3ztTh7f8GtqFRBbpLY8/PDBMPGmJBBw/BH3JtA8WNTnz hFJjt94LKQg4KqZBDPv4k3tyx8jkUjUgObV74JyFi2z8XubdRKsvLMxovFRseRaxAt3e AEVDTAgGyIVfdzL/xUm5/8AFDxufhR/FhIea7yFbhWpyrq1px3cNf/7v3+s/apYLr7Eu +dT2oI1wIFm6xbnWzIlmB+kHvlNfE3h8t3zdnwbvFsUh+YW64A7G97q9ksorGV3YOZdK +6ZiKTNCtZEf5Cv26Ocs+8TtT3UmbiF5aZytTGztBLsXL6v/3r60rPpai6S332oNiwIG oGqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YUWF7rka; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n15-20020aa7db4f000000b0045d189ac612si125096edt.402.2022.11.04.11.22.17; Fri, 04 Nov 2022 11:22:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YUWF7rka; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231646AbiKDSRz (ORCPT + 67 others); Fri, 4 Nov 2022 14:17:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231704AbiKDSRx (ORCPT ); Fri, 4 Nov 2022 14:17:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 182A84AF10; Fri, 4 Nov 2022 11:17:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7FC6A622CF; Fri, 4 Nov 2022 18:17:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82585C433D6; Fri, 4 Nov 2022 18:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667585871; bh=+s7AlmNkXcrzJIwGGzPCZdQ14D8AJ39RrEPQjJrIyYk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YUWF7rkaCq/e75m/fyfFCNq0yiaFrK73pgw2ggsLo3+PYU4/CefGpboFPMZRvpNmX YaZ8cIXXkWYu6pXN/y4vbm/cTSpICeCinzWfO06s2jTKgtEDuBpbsaRHHy0mHkfZQQ EwZlXm2sADM3umEjqOp1qqkMCsFm4bsef4Wvc8XMWz/hqmJUlbY/xxvR7u39MaEchp 1zaK5lxZkPLfcIvJqGJg9WlOqP+MfZiz85g54ohKCnhGsSpYv6F6zLRs5NrrJzH9Ff KACYrnRjlPd22REl3/0IRTBwnqGQQIn1Ro5vchScGt9p/rDLbmaErQ2XpLY2e1DvhG xHHGyJxxkkdzw== Date: Fri, 4 Nov 2022 11:17:50 -0700 From: Jakub Kicinski To: Colin Ian King Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Kalle Valo , "David S . Miller" , Eric Dumazet , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath9k: Remove unused variable mismatch Message-ID: <20221104111750.2b323850@kernel.org> In-Reply-To: <20221104140723.226857-1-colin.i.king@gmail.com> References: <20221104140723.226857-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 4 Nov 2022 14:07:23 +0000 Colin Ian King wrote: > Variable mismatch is just being incremented and it's never used anywhere > else. The variable and the increment are redundant so remove it. > > Signed-off-by: Colin Ian King Good sir, you don't have to CC netdev on wireless patches. Especially trivial ones. I'm saying this because you're a major contributor and I presume you send patches based on some scripted integration with get_maintainer so I hope this could nudge you to improve get_maintainer itself? :) Perhaps any entry which has a tree specified should mask off entries higher up?