Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1791320rwb; Mon, 7 Nov 2022 05:58:50 -0800 (PST) X-Google-Smtp-Source: AMsMyM5peNTSFfOLdR55Uw0ZQ/sPodvnk/qZ9fjNJ2wHew5WPRHw1H1wCknjXPCzzsEXyd9Pza0w X-Received: by 2002:a50:eb05:0:b0:457:c6f5:5f65 with SMTP id y5-20020a50eb05000000b00457c6f55f65mr49696526edp.311.1667829530629; Mon, 07 Nov 2022 05:58:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667829530; cv=none; d=google.com; s=arc-20160816; b=NqBoeaol++StlIz5X/c38qMtQayTh1s2wbkRqAp+IlBVn0NhGfQDs9dtz8eMAqyoD5 HP6rhFEM+UnBJOjzibJaJF4W1HRYS5OW6ymBMXyOqlRUiHPF8CxJq2psRsA3k43U3LmE K6Tz5aI/0UyK4ZNRs9GDpfCNsrl7V3RIj3nRKj9SlqtrGnOAC6V69f5ZveF1wLbkyTRf QgxjB1byNbyQrwQF6+k8pdNvVXakbS6ASU6PiMtBxm5lAty6k/+V0xj6f3Ja1xPgqPL7 SeFk4rlhogbKXuXqQ+MmGYO5p/BRD8KTc8jZz8Ss30OfC8nXapqLJ0nfnSgOzsVw/eQD p74w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:dkim-signature; bh=QjPOqkJJ7THxaf5gjdt6uYALkFt3BKSMw3rc8b0SEds=; b=S2tP53q/GX1keQG5muRg2r5Do2BLxW2ZeAhmE3og4TWBWHdmYzdTHL9dM5LHOfn6lw FRY/QO6E+uoci3wAnYPgOAWwDuALxI2r/gYFtezUoksr80+co0HW2L15p5n6LF64njFP sI05m3b7CoqdIBiC/OBu2wkGMiC2Zjhcr+6YfXnyqoZmGW77PmomL4NfVcvryCEVTKjW kUFfHeDwGWSqAQ8zG9baG8aVW6siSlx0S96yj+VEfkv5I0kh1pCUK44RP9ILEy4eHDNS 68tMCLkl8lLErkqInl1Ry5YrEPNsXAsv2q9NdGbBO4c1vL0co39g6NwYEmZ2T6jVemJR vYlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=paW98QAc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs15-20020a170906d1cf00b0078e54eda758si7161240ejb.611.2022.11.07.05.58.34; Mon, 07 Nov 2022 05:58:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=paW98QAc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231733AbiKGNzG (ORCPT + 67 others); Mon, 7 Nov 2022 08:55:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231563AbiKGNzE (ORCPT ); Mon, 7 Nov 2022 08:55:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4D281CFCC; Mon, 7 Nov 2022 05:55:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6CF42B811B8; Mon, 7 Nov 2022 13:55:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66B33C433C1; Mon, 7 Nov 2022 13:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667829300; bh=YmHzZ1me/URX0OErpUUTrYtcYN0+M7i/wabiD4jO+zY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=paW98QAcHGYOPQmIhc64P4PCa5Sd8UrU7apa81sMI2p3j4IB1/m5Kn07yeFTYaR2Y 07LZzTNfjivsKCo40T4Dpj9xORW+XR1jcm5Fghz9xBVLWWJ264M7Yu3pUD63MP8cdV 8Ij40TVjHSDoKG8vTf8jiWTFRgD7jqtcqPI04lxGzC8aEnevsSZbTD8iD0DnrLzbwH Amcs1WyhO+vEkkRhkbuRnQPyOUGE1PxL1YmCIuSVCWZfcIJ9QYXXSHz3JADDaEwanV iVkjjIzHf1SG2F8lPYioBOs9mowphmSzVFcv/hXpsGYnXQ6h4A9/EFsTh+Pi5wbB/L Dco7mCfq9GxEw== From: Kalle Valo To: Marek Vasut Cc: linux-wireless@vger.kernel.org, Amitkumar Karwar , Angus Ainslie , Jakub Kicinski , Johannes Berg , Martin Fuzzey , Martin Kepplinger , Prameela Rani Garnepudi , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org Subject: Re: [PATCH v5] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port In-Reply-To: <7a3b6d5c-1d73-1d31-434f-00703c250dd6@denx.de> (Marek Vasut's message of "Mon, 7 Nov 2022 14:23:37 +0100") References: <20221104163339.227432-1-marex@denx.de> <87o7tjszyg.fsf@kernel.org> <7a3b6d5c-1d73-1d31-434f-00703c250dd6@denx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Mon, 07 Nov 2022 15:54:52 +0200 Message-ID: <877d06g98z.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Marek Vasut writes: >> BTW did you test this on a real device? > > Yes, SDIO RS9116 on next-20221104 and 5.10.153 . Very good, thanks. > What prompts this question ? I get too much "fixes" which have been nowhere near real hardware and can break the driver instead of fixing anything, especially syzbot patches have been notorious. So I have become cautious. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches