Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221104163339.227432-1-marex@denx.de> <87o7tjszyg.fsf@kernel.org>
 <7a3b6d5c-1d73-1d31-434f-00703c250dd6@denx.de> <877d06g98z.fsf@kernel.org> <afe318c6-9a55-1df2-68b4-d554d4cecd5a@denx.de>
In-Reply-To: <afe318c6-9a55-1df2-68b4-d554d4cecd5a@denx.de>
Reply-To: martin.fuzzey@flowbird.group
From:   "Fuzzey, Martin" <martin.fuzzey@flowbird.group>
Date:   Mon, 7 Nov 2022 17:50:05 +0100
Message-ID: <CANh8QzxiJYAttQx=Jgufwq=bxe7s9X-6o1gpd=nBbxsw3VX+Jg@mail.gmail.com>
Subject: Re: [PATCH v5] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via
 control port
To:     Marek Vasut <marex@denx.de>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        Angus Ainslie <angus@akkea.ca>,
        Jakub Kicinski <kuba@kernel.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        Martin Kepplinger <martink@posteo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
        Siva Rebbagondla <siva8118@gmail.com>, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 7 Nov 2022 at 15:44, Marek Vasut <marex@denx.de> wrote:
> I'm afraid this RSI driver is so poorly maintained and has so many bugs,
> that, there is little that can make it worse. The dealing I had with RSI
> has been ... long ... and very depressing. I tried to get documentation
> or anything which would help us fix the problems we have with this RSI
> driver ourselves, but RSI refused it all and suggested we instead use
> their downstream driver (I won't go into the quality of that). It seems
> RSI has little interest in maintaining the upstream driver, pity.
>

Yes I've had similar problems with RSI.

It seems things have gone downhill a lot since RSI was taken over by
Silabs and the people who wrote the driver initially left.
The last mainline patches from anyone at Redpine / Silabs seem to date
back to 2019.

But https://github.com/SiliconLabs/RS911X-nLink-OSD/blob/master/ReleaseNotes_OSD.pdf
 it still says in the latest (March 2022) version
"The contents of this driver will be submitted to kernel community
continuously" which does not seem to be the case.

> I've been tempted to flag this driver as BROKEN for a while, to prevent
> others from suffering with it. Until I send such a patch, you can expect
> real fixes coming from my end at least.

We still use it too but haven't run into the issue this patch
addresses as we are still on wpa supplicant 2.9
If we run into any more problems I'll try to fix and upstream but, due
to all the above, I have already recommended internally that we move
to other hardware for future devices.

Martin