Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     <linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH 17/50] wifi: ath12k: add dp_tx.c
References: <20220812161003.27279-1-kvalo@kernel.org>
        <20220812161003.27279-18-kvalo@kernel.org>
        <de6d5e1a-0ff4-a303-ed25-508816a39a0d@quicinc.com>
Date:   Tue, 08 Nov 2022 15:14:18 +0200
In-Reply-To: <de6d5e1a-0ff4-a303-ed25-508816a39a0d@quicinc.com> (Jeff
        Johnson's message of "Wed, 17 Aug 2022 16:35:27 -0700")
Message-ID: <87v8npeggl.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 8/12/2022 9:09 AM, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> (Patches split into one patch per file for easier review, but the final
>> commit will be one big patch. See the cover letter for more info.)
>>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>> ---
>>   drivers/net/wireless/ath/ath12k/dp_tx.c | 1206 +++++++++++++++++++++++++++++++
>>   1 file changed, 1206 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c
>> b/drivers/net/wireless/ath/ath12k/dp_tx.c
>
> snip
>
>> +static struct ath12k_tx_desc_info *ath12k_dp_tx_assign_buffer(struct ath12k_dp *dp,
>> +							      u8 pool_id)
>> +{
>> +	struct ath12k_tx_desc_info *desc = NULL;
>
> nit: initializer always overwritten

Now fixed.

>> +int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif,
>> +		 struct sk_buff *skb)
>> +{
>> +	struct ath12k_base *ab = ar->ab;
>> +	struct ath12k_dp *dp = &ab->dp;
>> +	struct hal_tx_info ti = {0};
>> +	struct ath12k_tx_desc_info *tx_desc = NULL;
>> +	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
>> +	struct ath12k_skb_cb *skb_cb = ATH12K_SKB_CB(skb);
>> +	struct hal_tcl_data_cmd *hal_tcl_desc;
>> +	struct hal_tx_msdu_ext_desc *msg;
>> +	struct sk_buff *skb_ext_desc;
>> +	struct hal_srng *tcl_ring;
>> +	struct ieee80211_hdr *hdr = (void *)skb->data;
>> +	struct dp_tx_ring *tx_ring;
>> +	u8 pool_id;
>> +	u8 hal_ring_id;
>> +	int ret;
>> +	u8 ring_selector = 0, ring_map = 0;
>
> nit: ring_selector initializer always overwritten

Fixed.

>> +int ath12k_dp_tx_htt_monitor_mode_ring_config(struct ath12k *ar, bool reset)
>> +{
>> +	struct ath12k_base *ab = ar->ab;
>> +	int ret = 0;
>
> nit: initializer always overwritten

Fixed.

>> +int ath12k_dp_tx_htt_rx_monitor_mode_ring_config(struct ath12k *ar, bool reset)
>> +{
>> +	struct ath12k_base *ab = ar->ab;
>> +	struct ath12k_dp *dp = &ab->dp;
>> +	struct htt_rx_ring_tlv_filter tlv_filter = {0};
>> +	int ret = 0, ring_id = 0;
>
> nit: both initializers always overwritten

Both fixed.

>> +int ath12k_dp_tx_htt_tx_monitor_mode_ring_config(struct ath12k *ar, bool reset)
>> +{
>> +	struct ath12k_base *ab = ar->ab;
>> +	struct ath12k_dp *dp = &ab->dp;
>> +	struct htt_tx_ring_tlv_filter tlv_filter = {0};
>> +	int ret = 0, ring_id = 0;
>
> nit: ring_id initializer always overwritten

ring_id initialisation fixed now, but also ret is not initialised
anymore.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches