Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jes Sorensen <jes.sorensen@gmail.com>
Message-ID: <61438e78-7e84-e8e2-e822-8f477a206aeb@gmail.com>
Date:   Tue, 8 Nov 2022 08:55:42 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 3/3] wifi: rtl8xxxu: Rename
 rtl8xxxu_8188f_channel_to_group
Content-Language: en-US
To:     Bitterblue Smith <rtl8821cerfe2@gmail.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <bef90bf8-716f-c92f-9403-12ef2bfefc15@gmail.com>
 <ba8e3ea2-74f5-e1db-296e-4ae5f03084dc@gmail.com>
In-Reply-To: <ba8e3ea2-74f5-e1db-296e-4ae5f03084dc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/5/22 18:54, Bitterblue Smith wrote:
> This name is an anomaly. Change it to rtl8188f_channel_to_group to
> follow the same pattern as the other functions.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
> v2:
>  - No change.
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Jes Sorensen <jes@trained-monkey.org>

> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> index 4d044a8baa30..0f77312dd0ca 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> @@ -352,7 +352,7 @@ static int rtl8188fu_identify_chip(struct rtl8xxxu_priv *priv)
>  	return ret;
>  }
>  
> -static void rtl8xxxu_8188f_channel_to_group(int channel, int *group, int *cck_group)
> +static void rtl8188f_channel_to_group(int channel, int *group, int *cck_group)
>  {
>  	if (channel < 3)
>  		*group = 0;
> @@ -378,7 +378,7 @@ rtl8188f_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40)
>  	u8 cck, ofdmbase, mcsbase;
>  	int group, cck_group;
>  
> -	rtl8xxxu_8188f_channel_to_group(channel, &group, &cck_group);
> +	rtl8188f_channel_to_group(channel, &group, &cck_group);
>  
>  	cck = priv->cck_tx_power_index_A[cck_group];
>