Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     <linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH 36/50] wifi: ath12k: add pci.h
References: <20220812161003.27279-1-kvalo@kernel.org>
        <20220812161003.27279-37-kvalo@kernel.org>
        <d6323a12-0a7c-af50-7fc6-d996eb24a02f@quicinc.com>
Date:   Tue, 08 Nov 2022 16:56:45 +0200
In-Reply-To: <d6323a12-0a7c-af50-7fc6-d996eb24a02f@quicinc.com> (Jeff
        Johnson's message of "Thu, 18 Aug 2022 16:18:04 -0700")
Message-ID: <87zgd1cx5e.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 8/12/2022 9:09 AM, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> (Patches split into one patch per file for easier review, but the final
>> commit will be one big patch. See the cover letter for more info.)
>>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>> ---
>>   drivers/net/wireless/ath/ath12k/pci.h | 132 ++++++++++++++++++++++++++++++++++
>>   1 file changed, 132 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/pci.h
>> b/drivers/net/wireless/ath/ath12k/pci.h
> [...]
>> +struct ath12k_msi_user {
>> +	char *name;
>
> should this be const?

Fixed.

>> +	int num_vectors;
>> +	u32 base_vector;
>> +};
>> +
>> +struct ath12k_msi_config {
>> +	int total_vectors;
>> +	int total_users;
>> +	struct ath12k_msi_user *users;
>
> should this be const?

This is fixed.

> then the following typecast in pci.c would not be necessary:
>
> static const struct ath12k_msi_config ath12k_msi_config[] = {
> 	{
> [...]
> 		.users = (struct ath12k_msi_user[]) {
> [...]
> 		},
> [...]

But I couldn't figure out how to remove the cast, I got compiler errors
whatever I tried. I added to todo and will revisit later.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches