Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 4/4] wifi: mt76: mt7915: enable coredump support
To:     Ryder Lee <ryder.lee@mediatek.com>, Felix Fietkau <nbd@nbd.name>,
        linux-wireless@vger.kernel.org
Cc:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek@lists.infradead.org
References: <26aefa69d1002616412c4b00bf2e779f71ca3289.1667929344.git.ryder.lee@mediatek.com>
 <b26b285a001be954967ec77a1772a8b51faee21a.1667929344.git.ryder.lee@mediatek.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <f46cf0a9-c94f-aec4-1513-4b463107bbf1@candelatech.com>
Date:   Tue, 8 Nov 2022 11:25:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <b26b285a001be954967ec77a1772a8b51faee21a.1667929344.git.ryder.lee@mediatek.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/8/22 11:02 AM, Ryder Lee wrote:
> Host triggered and catastrophic event triggered firmware core dumping
> for basic firmware issues triage, including state reporting, task/irq
> info, function calltrace and MCU memory dump.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
>   .../net/wireless/mediatek/mt76/mt7915/Kconfig |   1 +
>   .../wireless/mediatek/mt76/mt7915/Makefile    |   3 +-
>   .../wireless/mediatek/mt76/mt7915/coredump.c  | 409 ++++++++++++++++++
>   .../wireless/mediatek/mt76/mt7915/coredump.h  | 136 ++++++
>   .../wireless/mediatek/mt76/mt7915/debugfs.c   |   4 -
>   .../net/wireless/mediatek/mt76/mt7915/init.c  |  12 +-
>   .../net/wireless/mediatek/mt76/mt7915/mac.c   |  72 ++-
>   .../net/wireless/mediatek/mt76/mt7915/mmio.c  |  59 ++-
>   .../wireless/mediatek/mt76/mt7915/mt7915.h    |  22 +
>   .../net/wireless/mediatek/mt76/mt7915/regs.h  |  34 +-
>   10 files changed, 740 insertions(+), 12 deletions(-)
>   create mode 100644 drivers/net/wireless/mediatek/mt76/mt7915/coredump.c
>   create mode 100644 drivers/net/wireless/mediatek/mt76/mt7915/coredump.h

Please add a pr_err() or similar somewhere so that it is easier to see that
firmware crashed while looking at dmesg/etc.

And maybe suggestion of where to send the dump so that someone can get some
useful data out of it.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com