Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4536506rwb; Sun, 13 Nov 2022 07:59:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf7UX6iyhb+JT4Eya6h5+1ZipM+ioMjFkXlXRuWQj4a4ID2zuZq9aj5cAF2bPZH9oTAQuGmY X-Received: by 2002:a05:6402:c12:b0:461:9cbd:8fba with SMTP id co18-20020a0564020c1200b004619cbd8fbamr8621880edb.19.1668355162617; Sun, 13 Nov 2022 07:59:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668355162; cv=none; d=google.com; s=arc-20160816; b=RHO9Nsmg2TjYhvR9gxgZzEgYdxTo+Lb7sHRSV0Ench8jBzQGq1h44gUTHbpbsmVKj0 PpNS9blsSnCkSnPamByuiG33O2M+b+k8lD84OoSG113COqooetAuTH8km2t5C55FrInC mGRjjc2a8kCBJzrRgEut7i/qYCP46hzAKBRh2yGDf2VGcialIe/NHO0AfeX3AGkNr4dA eBIkGmuwtw0vVEXrFh0NKEyiXwgUnfyp4oH/6mi9QXXWX4LPDsl3La3U9bvIA+20qLw3 OqeBR8NuQnQOeDMWoh5M1v3kA0CmmmN4GW1/QNElZK0irVV4jN0KSznkie3gKwN5/t4+ HBuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3V2KVznZkr6yAhsXAKAHxuC05v2JFcez2hto47mbuac=; b=roAelswczrp2iIONVreb6Vb+DL49cCr5FzNTQkU8vK1FzJnlFUNYxupvttOZXJJX+Z NB9PFxv3kbnq0F2mOb+7NMVljMGjmwTMeLz1Z6zjs+ZpIN7ZdQNQZArdmW3mtdzk7Qft a0HdmqOPUppSEr4umk+IoSkwqyQrEjjRhOdxyqOXzImikmILkmiZPL/4oqQVt/++Nan+ Qcg6q/JGwj15igcRrIBOh7yFVbh/DNU3/3nk9oNWi+x+6NGKjx6V5EBpMygQVfiJ8dUA ynjXy+4nG8urYM/zd15vgRKzdL4SBSLY7t15aInlFUKQQnAwCG7pBsNFy9+6JzfZ8RYj bLJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b26-20020a17090636da00b0078d2848bca9si5399752ejc.704.2022.11.13.07.59.03; Sun, 13 Nov 2022 07:59:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235316AbiKMPt2 (ORCPT + 66 others); Sun, 13 Nov 2022 10:49:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235223AbiKMPt1 (ORCPT ); Sun, 13 Nov 2022 10:49:27 -0500 Received: from smtp.smtpout.orange.fr (smtp-18.smtpout.orange.fr [80.12.242.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECE17B86A for ; Sun, 13 Nov 2022 07:49:26 -0800 (PST) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id uFEXoEoZTXaJmuFEYoHaCh; Sun, 13 Nov 2022 16:49:24 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 13 Nov 2022 16:49:24 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET To: Ping-Ke Shih , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc() Date: Sun, 13 Nov 2022 16:49:18 +0100 Message-Id: <7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org 'ret' is not updated after a function call in rtw89_core_sta_assoc(). This prevent error handling from working. Add the missing assignment. Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") Signed-off-by: Christophe JAILLET --- drivers/net/wireless/realtek/rtw89/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c index e716b96d0f56..f30aadc41f2b 100644 --- a/drivers/net/wireless/realtek/rtw89/core.c +++ b/drivers/net/wireless/realtek/rtw89/core.c @@ -2535,7 +2535,7 @@ int rtw89_core_sta_assoc(struct rtw89_dev *rtwdev, } /* update cam aid mac_id net_type */ - rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL); + ret = rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL); if (ret) { rtw89_warn(rtwdev, "failed to send h2c cam\n"); return ret; -- 2.34.1