Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da2bca7b-1289-747c-df11-fb424381c6e6@denx.de>
Date:   Sun, 13 Nov 2022 19:59:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v5] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via
 control port
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, Angus Ainslie <angus@akkea.ca>,
        Jakub Kicinski <kuba@kernel.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        Martin Fuzzey <martin.fuzzey@flowbird.group>,
        Martin Kepplinger <martink@posteo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
        Siva Rebbagondla <siva8118@gmail.com>, netdev@vger.kernel.org
References: <20221104163339.227432-1-marex@denx.de>
 <87o7tjszyg.fsf@kernel.org> <7a3b6d5c-1d73-1d31-434f-00703c250dd6@denx.de>
 <877d06g98z.fsf@kernel.org> <afe318c6-9a55-1df2-68b4-d554d4cecd5a@denx.de>
 <871qqccd5i.fsf@kernel.org> <1c37e3f3-0616-3d60-6572-36e9f5aa0d59@denx.de>
 <87zgczs6zl.fsf@kernel.org>
Content-Language: en-US
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <87zgczs6zl.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/10/22 06:39, Kalle Valo wrote:
> Marek Vasut <marex@denx.de> writes:
> 
>> On 11/9/22 17:20, Kalle Valo wrote:
>>> Marek Vasut <marex@denx.de> writes:
>>>
>>>> On 11/7/22 14:54, Kalle Valo wrote:
>>>>> Marek Vasut <marex@denx.de> writes:
>>>>>
>>>>>>> BTW did you test this on a real device?
>>>>>>
>>>>>> Yes, SDIO RS9116 on next-20221104 and 5.10.153 .
>>>>>
>>>>> Very good, thanks.
>>>>>
>>>>>> What prompts this question ?
>>>>>
>>>>> I get too much "fixes" which have been nowhere near real hardware and
>>>>> can break the driver instead of fixing anything, especially syzbot
>>>>> patches have been notorious. So I have become cautious.
>>>>
>>>> Ah, this is a real problem right here.
>>>>
>>>> wpa-supplicant 2.9 from OE dunfell 3.1 works.
>>>> wpa-supplicant 2.10 from OE kirkstone 4.0 fails.
>>>>
>>>> That's how I ran into this initially. My subsequent tests were with
>>>> debian wpa-supplicant 2.9 and 2.10 packages, since that was easier,
>>>> they (2.10 does, 2.9 does not) trigger the problem all the same.
>>>>
>>>> I'm afraid this RSI driver is so poorly maintained and has so many
>>>> bugs, that, there is little that can make it worse. The dealing I had
>>>> with RSI has been ... long ... and very depressing. I tried to get
>>>> documentation or anything which would help us fix the problems we have
>>>> with this RSI driver ourselves, but RSI refused it all and suggested
>>>> we instead use their downstream driver (I won't go into the quality of
>>>> that). It seems RSI has little interest in maintaining the upstream
>>>> driver, pity.
>>>>
>>>> I've been tempted to flag this driver as BROKEN for a while, to
>>>> prevent others from suffering with it.
>>>
>>> That's a pity indeed. Should we at least mark the driver as orphaned in
>>> MAINTAINERS?
>>>
>>> Or even better if you Marek would be willing to step up as the
>>> maintainer? :)
>>
>> I think best mark it orphaned, to make it clear what the state of the
>> driver really is.
>>
>> If RSI was willing to provide documentation, or at least releases
>> which are not 30k+/20k- single-all-in-one-commit dumps of code, or at
>> least any help, I would consider it. But not like this.
> 
> Yeah, very understandable. So let's mark the driver orphaned then, can
> someone send a patch?

Done