Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 15:07:03 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Ray Jantz <ray.jantz@gmail.com>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [BUG REPORT] mt76: LED not working on ASUS AC51 USB (mt7610U)
Message-ID: <Y3JLhx3jfCF8zL3a@lore-desk>
References: <ba072331-b7db-edc3-de77-4496d402f497@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2VUFC7saVm+CVx5e"
Content-Disposition: inline
In-Reply-To: <ba072331-b7db-edc3-de77-4496d402f497@gmail.com>
Precedence: bulk


--2VUFC7saVm+CVx5e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Hi,
> Below is a bug I submitted on Suse bugzilla - they said I should it submit
> it to linux-wireless.
>=20
> LED not working on ASUS AC51 wireless USB adapter (MT7610U chipset) using
> Mediatek driver
>=20
> The activity LED on my ASUS AC51 wireless USB adapter does not flash when=
 there is link activity. Everything else works - the adapter connects to wi=
reless networks, but the LED never flashes.  The LED works fine in Windows =
10.
>=20
> Reproducible: Always
>=20
> Steps to Reproduce:
> 1. Plug ASUS AC51 adapter into a USB port.
> 2. No need to install a driver (driver is in-kernel)
> 3.(Optional) reboot
> 4. Connect to wireless network.
> 5. Open a browser and bring up a web page.
> Actual Results:
> The activity LED on the AC51 never flashes even though there is network a=
ctivity.
>=20
> Expected Results:
> The activity LED on the AC51 should flash when there is network activity.
>=20
> The OS is Opensuse Tumbleweed 6.0.5-1-default.
>=20
> The info from lsusb is:
>=20
> ASUSTek Computer, Inc. AC51 802.11a/b/g/n/ac Wireless Adapter [Mediatek M=
T7610U]
>=20
> Bus 001 Device 003: ID 0b05:17d1 ASUSTek Computer, Inc. AC51 802.11a/b/g/=
n/ac Wireless Adapter [Mediatek MT7610U]
>=20
> I have checked the kernel config file and  CONFIG_MT76_LEDS=3Dy is set.
>=20

In the current codebase mt76_leds is only supported for mmio devices since
afaik mac80211 requires the driver led callbacks to be atomic while usb
configuration path can't run in atomic context.
I will work on a solution to overcome this problem.

Regards,
Lorenzo

--2VUFC7saVm+CVx5e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCY3JLhgAKCRA6cBh0uS2t
rJL0AQDOelTL6S/EFAOL8GtotfMk4a39/mn304PtWZ18XrqqWAEA+WQGr9woxpgg
OAsn1IvBYkWpZ6eCkkGFBitydhkcuQ0=
=AG0G
-----END PGP SIGNATURE-----

--2VUFC7saVm+CVx5e--