Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp366799rwb; Wed, 16 Nov 2022 01:36:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf7SndMjygOX5s5cOQYg+ALi9eHQWrA62HpPbGeCAuA8GQ2RDk3S9OMY5j+zhgUN02AjNPrS X-Received: by 2002:a17:906:a1d3:b0:78d:9022:f146 with SMTP id bx19-20020a170906a1d300b0078d9022f146mr16407516ejb.656.1668591394424; Wed, 16 Nov 2022 01:36:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668591394; cv=none; d=google.com; s=arc-20160816; b=puvcAuM7+JO3PWeqaabSTjkG3afR7u1y/+6ETSNp1EoNE+ebuhJZfX+f+PS34E7E/8 eafS3CYyTSpMPCRmtVW+1xv7xvvx2FIENKRCuLhyMYGMLv8IQkFHOXBklvHO7pymMF6Y SQNixaLdQmhGrHWBhhkoT4YFya1GbT9mQL8+Qj2KSq9BTWXEKMdhTZS8FNShcASulA78 3KzSeLESRHLTiBW/Uu82cj6idXPPJdaUkHtCFWkvsoyqv0yxbiqX+o5201rbKZyC9A3M nFfc7VujrDm9Cwp+hgrQRDzBKQ1cuAxomlCW8mRMNbIKKuAIRK+2MiE1BrwxwGwcT66g xvlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=LzdODOOCWqtIOLapMUN3d/zWO94XOYdfU+UOCDzOSkE=; b=pZvcKa5UMLoa31j3OaMSqJwKB3w0pPZrwTL2brbM+1imyAQjCUU06LU4Bw18sWYw0v Yi0JY6/WWt7aPmFyPF7KdPPxhnc/KtkChMnpOtR5jq5tl0OkblxrfvqP8S9W5tlFLcuv Po+wTha8oZMZ0CAjCagSwSep+Qk1kV+W9PRgLOjSRNskEyVTybw0twF/bXuKBDqoxsRK ICkCcWWR7b5y+hK/pPYg04im+lrJ9CEccn6asAgMSe88XOHbaOiaM2CVIW9Q758Mohfa 7TlKAKqAR+u+UbVsk6QWoVXmQoG+fjUtZipiRV2fFtKjc4vXfA7XWdMugCYKhu5McVVW v/rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pbXAsseY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb6-20020a1709076d8600b0073dced7204bsi14518036ejc.767.2022.11.16.01.36.17; Wed, 16 Nov 2022 01:36:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pbXAsseY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233507AbiKPJdX (ORCPT + 67 others); Wed, 16 Nov 2022 04:33:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232019AbiKPJdW (ORCPT ); Wed, 16 Nov 2022 04:33:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 760C012AA7; Wed, 16 Nov 2022 01:33:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29F5CB81C21; Wed, 16 Nov 2022 09:33:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CAAEC433C1; Wed, 16 Nov 2022 09:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668591198; bh=oiqJ939Mq4wKHx4zNsuCeZhl6jCHPbHMVW7rkxEToCQ=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=pbXAsseYlki20xQ6ZltMls18XrTBw8LiOcLd+KzzDn/PBAJLQW65dvy6U3OprBq+x /9EQ+WMNmpWVhTF2ny4E2Sz0AtvsaZ2P2DRRrJ7CkX32NrUQQB0VwiJeskLwdqBwaU N/wV4YhnPP7UK0g61XTyCSFWD8U1ksbit7NUDeu4pBVUth4n0ihFYTA+/Mp5dt6BSb F9WG1jAUHOT5pcVx6kdvH2+0SI9Nn6FwqXAypXbgEBE2z4paQZXBAq0KNRJO7j/iv3 EBUETmJBPY51X8bXEnLEXa9x7hjajEdaj2RrGktDph97c8hL545pza4sLLgSFpPNJP tqI4rn4IsEHwQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_wow_enable() From: Kalle Valo In-Reply-To: <32320176eeff1c635baeea25ef0e87d116859e65.1668354083.git.christophe.jaillet@wanadoo.fr> References: <32320176eeff1c635baeea25ef0e87d116859e65.1668354083.git.christophe.jaillet@wanadoo.fr> To: Christophe JAILLET Cc: Ping-Ke Shih , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chin-Yen Lee , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166859119398.16887.2462368956174641682.kvalo@kernel.org> Date: Wed, 16 Nov 2022 09:33:16 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christophe JAILLET wrote: > 'ret' is not updated after several function calls in rtw89_wow_enable(). > This prevent error handling from working. > > Add the missing assignments. > > Fixes: 19e28c7fcc74 ("wifi: rtw89: add WoWLAN function support") > Signed-off-by: Christophe JAILLET > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 61ec34dee266 wifi: rtw89: Fix some error handling path in rtw89_wow_enable() -- https://patchwork.kernel.org/project/linux-wireless/patch/32320176eeff1c635baeea25ef0e87d116859e65.1668354083.git.christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches