Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp368810rwb; Wed, 16 Nov 2022 01:38:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf60tkDrwcCYtRKG7sbZqzfTsTp1TAJCV7PqFgie7cBfXNoLzU+OuctMtSSct6Y9Zz8sLHnT X-Received: by 2002:a17:907:9551:b0:79d:f5f2:621e with SMTP id ex17-20020a170907955100b0079df5f2621emr16224601ejc.362.1668591529481; Wed, 16 Nov 2022 01:38:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668591529; cv=none; d=google.com; s=arc-20160816; b=DXr5VOkjWPCB6mnurObamc9R3MZ2o63/at9/Ks+uiSZQJX2U6u2j7twsRqg2woJTFv flLeA2Dj1yq4tBm9lXJhofMIkG5vgd7ja+PWtwkHgZQNmK5u3TIeFfC8X34t/boY1Osf gOwsNCdvP4vehfOy+sHBX6BC1HNMhTjAJuWB4VMBrrBpdxE9o5SCeLewPkc3Pm6P2cYX ffsIXjx3GvF33ZUOAao7Cu8Za7loWTR0tpP0ThcBKlKFLIy+wniVK050zp6zb/OhzVY2 92WRjN4v3yRwj+98K5ovUX/g95h2zHn5ElhQ0SbHnIK8jO3HJohL4YxzImkFAitbeckf 3MOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=FYtwBXVEEneDzab9GPnkiIg/X+cK3sB3fbngN+MT8Jc=; b=dj/8wJwbL08AohpPq9qv4/BRvGEk1KhzPRIXohaju+MqrWKqz1Mm4qgq8CZTPnZDZO MuKWAo89KVLbEKhftUTCpmCH44IOW6khbsSCOTUYWdIlizheVkd0d4bG6DIdzgyuXiGb zUByFH7v5tCdQfIO5aEUn5KfSDydL/RSj1RZVIMRxzKzzf7+Jsqew/WDT8oPESeM9wHv sqLtOr/QAnyACmGhtc9w2QgnleIzqFCiDbQga+YnV4EZzDW5lcYPWzLsNDsw4ko4zwEU ZQAu2omEwh0kPyW645zkFKHcj0NbSiPdVB1W6Qhs7epAUgztzbYFGnWeQr8Tp55uz70D iL3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EJiPSar9; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a1709064e8e00b007973c84ba55si6605734eju.298.2022.11.16.01.38.32; Wed, 16 Nov 2022 01:38:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EJiPSar9; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233569AbiKPJd4 (ORCPT + 67 others); Wed, 16 Nov 2022 04:33:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231985AbiKPJdr (ORCPT ); Wed, 16 Nov 2022 04:33:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E28D425FD; Wed, 16 Nov 2022 01:33:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A414B81C21; Wed, 16 Nov 2022 09:33:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ED18C433D6; Wed, 16 Nov 2022 09:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668591224; bh=LJFi6Ma1wzYiDa5KLD8RjmUBaaBhQpd9Xx8w7okLL/0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=EJiPSar9fvYC8gxWIGNiU+SsZZ4gALbqU+ctlrwbqFlvFTAg49j5d5rebYCOq7eMh gHL2BUnvPCavqP+szIAv9HWDFrFGby4a35IKJ89s9lrBLLUOagDLTxbxbZ5LD5oe1y xvJ+DA+yWSohkqAM0Hv6H2gRr6RoBOmkSnb5aV5HpIkCGN5O03cA1DaazSNJZwds4m /2QMLb7ywnQtlXMLoLjH2jCCnzUMD5ORDn8ytoMHr1h42COptFk9Q1ap5XVY50G3Rh tZcW7hE3wOHMav2vqPQcIfVyXCHn3Zpwij88EGFveOGfPbe0uQM84U98TcfpFsy1/k 5PaEB2i1656AA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc() From: Kalle Valo In-Reply-To: <7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr> References: <7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr> To: Christophe JAILLET Cc: Ping-Ke Shih , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166859121959.16887.13694175362892729527.kvalo@kernel.org> Date: Wed, 16 Nov 2022 09:33:41 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christophe JAILLET wrote: > 'ret' is not updated after a function call in rtw89_core_sta_assoc(). > This prevent error handling from working. > > Add the missing assignment. > > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Christophe JAILLET > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 81c0b8928437 wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc() -- https://patchwork.kernel.org/project/linux-wireless/patch/7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches