Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1816908rwb; Thu, 17 Nov 2022 02:24:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf5u0xwq1hkqefN096Avo6n7LVQuVnRzp5u5cSX+Qv0wka0gHMnTYxfxyJsm9E7ey43YD8To X-Received: by 2002:a17:906:9d16:b0:7ae:c45b:98fb with SMTP id fn22-20020a1709069d1600b007aec45b98fbmr1553882ejc.478.1668680643460; Thu, 17 Nov 2022 02:24:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668680643; cv=none; d=google.com; s=arc-20160816; b=GOdLYASrHx0O0r8cVllLuwxDgq4Xf4xmT73To/td2zyn1TVzieij0hzOD/B6HdWSYs lyL5HomvpMRrIPjIgDEAh2Yocl/r0O2EHqbh4csf/LD0z4OSmKa4GAORC8maE9PFHiBy FD1iy3VrOGXdutW/eS7pFrQaftHFC+hDQCv28rZ7l5l0vjEvGRBsqETFucffYukJ0nk2 rQiIhrBRpkoMpR7Lzfj+iUwcGqtVD0Mw8F5cqTtumxxyqQsIqe7y6tJ1dmJnQqCPdIBm +qHdr8pkQYOQLrdp/quQoFqIDY16e6Xi9FxxTrsthHcA7KkUqngALiZ9jonTkx67ILL4 suBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=dotHnJOUzlENU6MAp8Of6GPoc9fmcSMv3TFZZTeJ+S0=; b=EHqXHzu2ZKr1NXB1vhY0eY8Rfq3VQ9fp5EkrtLpTes1eA7iagFGfL2NCLZMZLp1X2L 92/sGdElFE1j9W3eJqZlqCqw52O2El7yE3DPhKs9Pgz/aUk3h93Ju7fdvrnIpmYb/M8Q gxQPy2IocaXP5QFfrCMZ3Wc9bPc/QReZwjNafAfrdwS7UunzsSZ7CPU5eueN6e5Zh9sT 77MdXLRvYSYO0ntztiGWhAHEUB29pidRi7M430KqMfisRCsy+Asbc72xSeziyFrGSMWP M17o1D9COqUA4dAto4qNaR2QHekcoRwd6w0e9Sv1oeKfHVdZsZO4ZiccpglmddCxCdrt tNSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Eq32OjiG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sz15-20020a1709078b0f00b0077951929340si244237ejc.271.2022.11.17.02.23.47; Thu, 17 Nov 2022 02:24:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Eq32OjiG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239369AbiKQKKA (ORCPT + 67 others); Thu, 17 Nov 2022 05:10:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239338AbiKQKJz (ORCPT ); Thu, 17 Nov 2022 05:09:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E310E32BB9; Thu, 17 Nov 2022 02:09:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8E4A3B81FC9; Thu, 17 Nov 2022 10:09:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89F72C433D6; Thu, 17 Nov 2022 10:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668679792; bh=fh4h+my1vHfdEW4dXSNVVgKU5JyWQEijupVnZaEobzQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Eq32OjiGAfLNDs6XsCukpJDWhiTh8CHucHmSaAPE6nz4u0/3RKeuFbA8fQ85n7vzV fi27lkn6Gpeq5H03twBsYZcF2eER6EkUNVg0KtS7zWqjE3Mdqdve8dO8g/OODt77K1 Su173rrJANrrm/ZzInFwYwhBAV8QrROlMHHu1pSddygp4MhkpqbyetI3mR7FI2tbrl UBAXsETJ2xMmbS0MYKQP72PiKrzVjU/FreoFrZjNib5sHMxcUY1n0BHknbwahhIiE1 YuufflsoXpVkcRqHjn8nG8nc7hWc6iXBRdFz8tFcBnApy3QrJ+nni52R2Ra2iygJuD lYCiBX3N3aF3Q== From: Kalle Valo To: Zhang Changzhong Cc: Ajay Singh , Claudiu Beznea , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Johnny Kim , Greg Kroah-Hartman , Chris Park , Rachel Kim , "Nicolas Ferre" , , , Subject: Re: [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit() References: <1668657419-29240-1-git-send-email-zhangchangzhong@huawei.com> Date: Thu, 17 Nov 2022 12:09:47 +0200 In-Reply-To: <1668657419-29240-1-git-send-email-zhangchangzhong@huawei.com> (Zhang Changzhong's message of "Thu, 17 Nov 2022 11:56:58 +0800") Message-ID: <877cztsxhw.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Zhang Changzhong writes: > The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add > dev_kfree_skb() to fix it. > > Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") > Signed-off-by: Zhang Changzhong Same as in your other patch, have you tested this is on a real device? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches