Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1914221rwb; Thu, 17 Nov 2022 04:05:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf438fqilnGg0dOQ5WdMMRlurHxpidfs2fpVRyXbUaCgfNq13S5qtgIpf+yV7zebQNPOtisL X-Received: by 2002:a05:6402:f10:b0:467:9976:2e37 with SMTP id i16-20020a0564020f1000b0046799762e37mr1897394eda.267.1668686725597; Thu, 17 Nov 2022 04:05:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668686725; cv=none; d=google.com; s=arc-20160816; b=BElYX/ixZ7KgCq4iP8dUBuJFiYjot9narTPbQHaJL2Yj6XTv7m83NBrQ9E2QOixEjS 2ktaE6LTUOclaBItFsn3XooEwsqRjJeW6EiuZHIj8fIdfhqRiMg6KsoG3wHEbhldglfE ZhEeJzhmsjVdF6s1FM0OPbSQRghCcFbiITv6bPz4i9iecOiQlrTQxzW5AGifzhDobhD8 k+XjQmRf7e/X97MN6KSF4wUY1p0naTOxyIThTsu3BsD+OkkOrtM7tkjhjXzOH8u9b+f/ 3eNtFAF5wDKyo6EzNYKYsu7VZgmp5WFDGCsDTpdioGW3tmrQQmk/4SPg60pglCAsl/GU ZNtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=O0IU0JTIxZWkobbrAhqx54EIMQIEQglOBLnjEVBi+Lc=; b=yTN5Da/eoAl1uHM2UAG2DTA7tBiWy7GjonSClfxW6xUukZ0KVp7jEUzk0hH6uqAnQE M5KlfU8FCJc/tvm0JCfyriM2MXmpJ22w8fTs10SrWIh05vUMQk6DY2b/8KDXynRtK1gy VYBw5ijphDZZP2JG6eC38oMHsJJwde4XWq2n3IqDrq8irEmA79mAX9WTlQLl4Z6BlJXF 62tRADJK5C3swMKLFJ/elw/KCbovS0lHMIc8IaUWAvqk/gjo4A+i/0edVgts2NLv9taf ynVeizyIlUErO3noSUKcDU8Z6hMTqeVW7vK3ol65uVhfCM20qFtRJfHgZCDJUqkIIUIN 57vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hzff2FbW; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wy4-20020a170906fe0400b0078db89b2566si364407ejb.699.2022.11.17.04.05.09; Thu, 17 Nov 2022 04:05:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hzff2FbW; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239916AbiKQMEI (ORCPT + 67 others); Thu, 17 Nov 2022 07:04:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239760AbiKQMEG (ORCPT ); Thu, 17 Nov 2022 07:04:06 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F3CE5E9FA for ; Thu, 17 Nov 2022 04:04:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A76361564 for ; Thu, 17 Nov 2022 12:04:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 264ACC433D6; Thu, 17 Nov 2022 12:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668686644; bh=Ikq5sCPgb4XtQZfCV6zAGcn1drm+mhwPZncFZ+Fvdq0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Hzff2FbWP9+TtMFKGifeHDPfgg8phvXlbUzSDvaQk3IYN15hXa9B0bGvs7GkyAles 4GrVeAHN/A3lXWWp++zXsRT5qn7YI9eQp7KgAlRsoW4dmMPakpfWMJEAdjPPpHssew hgmpqCCWwdFx6YCf4uvlYLzivW9ROOEQhnYRIOYPAkcwjrpCrQiall3Xjla2WiSBm4 QkRGtQD0QjpIoaP0Wm+/Y18UinKKXzzp57wbl9D873vlxrXHwR+W1/yIdbZmtxwVhm oazlWYgQRk7oKWkWJ3jMcBpXS8Fm0uRXzNxOe9rVjGlLyhR0/sB1g3aNLHRPBq2Cew wDruEFaNJdB0Q== From: Kalle Valo To: Ryder Lee Cc: Felix Fietkau , , Lorenzo Bianconi , Shayne Chen , Evelyn Tsai , Subject: Re: [PATCH 4/4] wifi: mt76: mt7915: enable coredump support References: <26aefa69d1002616412c4b00bf2e779f71ca3289.1667929344.git.ryder.lee@mediatek.com> Date: Thu, 17 Nov 2022 14:04:00 +0200 In-Reply-To: (Ryder Lee's message of "Wed, 9 Nov 2022 03:02:10 +0800") Message-ID: <87mt8prdn3.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ryder Lee writes: > Host triggered and catastrophic event triggered firmware core dumping > for basic firmware issues triage, including state reporting, task/irq > info, function calltrace and MCU memory dump. If you add module parameters please always document them in the commit log. > +static bool coredump_memdump; > +module_param(coredump_memdump, bool, 0644); Please also add documentation here so that it's visible with modinfo command. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches