Received: by 2002:a05:622a:1442:b0:3a5:28ea:c4b9 with SMTP id v2csp669954qtx; Thu, 17 Nov 2022 04:58:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf6MH2VWr0U3/dnPacXh7hWXhoxFDDNlSzbmVqmetU7pO4rHO2GPZ2DB3MEQ6NOWm+9V5tRO X-Received: by 2002:a17:902:7c81:b0:186:9c32:79d9 with SMTP id y1-20020a1709027c8100b001869c3279d9mr2772228pll.47.1668689899614; Thu, 17 Nov 2022 04:58:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668689899; cv=none; d=google.com; s=arc-20160816; b=vq/XXX8xm199mAMhI+dzqXEgRhFS92hgUSgL636Is47a7bz8xNBifVYufZ6s3i16Ab KHkvxOzrAk4w6Byv2jQqSnbgYOnpM/N6Ydvq+hu4nCFdaslh7+QfohxAE3mhcKVM2uwP dyXxxTbDB1c7v58Ura+Y8K7OTeYKJaUjfktyTtU6tG6ySeWD7yOBOgh9Sm1PF75T8SGm +P3ThT0sW7Hn3IPAmke4h9PXBZrg0EPHL4qludjSw7OUO+y8s3+a0UyIrZ/TauXUgrqS pedFjxll79dmIN67mYJ/E0Al6DgAT474JmyynZheuISD2k0uV5Z0ZjXn6ziBG3fKLQ/1 +16Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=/EQ+/smu6lsZyckluXC+S7H4TJoI/muc5mVo9Di4C6Q=; b=pN4FZLhN/w6IF73a6UNYXphHYCAWZBojue3b943L7Lik9IgqyrpOk07re//esoO5xE Jtt3zDpK/DcLhHsAfqfNTekc7s4VwX8OkBYtfszeykXd/oOo+QpgXUeJUgfOtj8/wSqN AVgqI4A1ZcQibWZwTYHlLxu+XwZy9vawA3Y4kdLoCPFN1JqyqYzrmNfvQRZ2zES17diu fBUgghztkitFfFEgg9TDl9+9MyWFRR5vYbUbHwEladcOJK/Xj0ogRCgZXbmBXcm7b+1Z b3jO0nhkuNsZwbWJAcZyeNC+P7srgnikDlPSbzH8pjVXlZqP1dRKrGfWdUhuQRe+ES5z tDYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sGOk610N; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a65580e000000b004706a2c7d48si890892pgr.684.2022.11.17.04.58.10; Thu, 17 Nov 2022 04:58:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sGOk610N; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239310AbiKQM5R (ORCPT + 67 others); Thu, 17 Nov 2022 07:57:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234724AbiKQM5O (ORCPT ); Thu, 17 Nov 2022 07:57:14 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A80312497E; Thu, 17 Nov 2022 04:57:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 539E3B82047; Thu, 17 Nov 2022 12:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE637C433D6; Thu, 17 Nov 2022 12:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668689831; bh=ZOv2xrVLw6KOC97u6Z3qAeavQOyOIGJMgx0UM0hKo/E=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=sGOk610N3CduGTmOdPfuOT4PNjLz8I5lU6nN2aUENTa4ejgyLccsO3fLtFYjBRdpf T2irFWVv7K6q4+bhEShd+i1QU3gpog6quSWq7XiHhS9WqcgQXCA/UuSaUIHLjHsKRQ BR+CeJRqNkvGfPxPsXnXARlsIMFvoWtd/uqlxeg7EVuU017+GEeVK+m57IiGPRMqn0 XcwQtg5O69/i8A6mO4mianTfLiImbGmvTe+8B9LLGjJgVUlIMzkELU8WU8aVlGLLN7 ZtWbwOmN1b5y91nNEop79i3wu82uFjJSd/eYRXn2/wmG+0D+NOtqo01ZdjC9xb2Zgw HUTp5YgmlG4ng== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH RESEND v2] wifi: ath10k: Fix return value in ath10k_pci_init() From: Kalle Valo In-Reply-To: <20221110061926.18163-1-xiujianfeng@huawei.com> References: <20221110061926.18163-1-xiujianfeng@huawei.com> To: Xiu Jianfeng Cc: , , , , , , , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166868982720.22046.2839005153989061348.kvalo@kernel.org> Date: Thu, 17 Nov 2022 12:57:08 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Xiu Jianfeng wrote: > This driver is attempting to register to support two different buses. > if either of these is successful then ath10k_pci_init() should return 0 > so that hardware attached to the successful bus can be probed and > supported. only if both of these are unsuccessful should ath10k_pci_init() > return an errno. > > Fixes: 0b523ced9a3c ("ath10k: add basic skeleton to support ahb") > Signed-off-by: Xiu Jianfeng > Reviewed-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 2af7749047d8 wifi: ath10k: Fix return value in ath10k_pci_init() -- https://patchwork.kernel.org/project/linux-wireless/patch/20221110061926.18163-1-xiujianfeng@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches