Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1569650rwb; Fri, 18 Nov 2022 22:39:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf7yqIb+XVwFoTSqIR+0E49it0eT4HVnG+XoJnjeMPzvZnxEtuYLbpOQ6cONEPUq2lVQlKE/ X-Received: by 2002:a17:906:d782:b0:78d:422b:8156 with SMTP id pj2-20020a170906d78200b0078d422b8156mr8520930ejb.589.1668839987215; Fri, 18 Nov 2022 22:39:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668839987; cv=none; d=google.com; s=arc-20160816; b=Wqwt+ApSiXUMfefJykYqB0i51rVrp5fwuCs2wnMstUaE1STxRe9SfiBzM/Y5gGrCRb UCNh4ai0yZ9e2SRQqRuMs+/96YPJ9YQCeW8D44JxGGtseeh3ht0JODKvOni3KfcZn1Vy 4sZ3AAplbLv+5X+vr5pD8boZeiJ4p23uQq5ZfMuKOQ58//k5FiDHNyETAcNlDi+gxRlX yFJpXkDm1S5ejrXNmnbHzgopzjtMGwZ+ylAK1IOA3XX2TdfSzQSuJ9NVHIW/u4SORptY xcBb53dYezuMGfrqByZx4Y1Xlidqa69ea43FE2+bvMdAYiWyRKj/9wKnbbu+boT13Yzj 8Jag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=bPNyeewi9L8eKEyPv5RDFjGqEkg8IflzRpBIx14GhCc=; b=RrVNvjBX55ZPaSlgsrOFGi19b8D1KkVuaiysm9PXB+m+mKbfy2KzSMT4elwghpPoPa 7QbwSGl5hJhCN4hm98XmxtZxM8SLQQj4L3SXCoc4w2agnPqVarbL6fCmslB1v6GPV4Pt ehJVBXxkfezSdQQP1itDwTy2Qj9ItGmr9ppme44DEQdpXRuiUqnldsHI50NWyNlSBOjr TOilB8EscG47sSXM39sDzW1ARqRKHSHfrbEqo6c/UGoljkHpsqdPrCn4U642mHubComo 85lPAlKpfnf32DiyRxzQ7fWB9hR65qo2rxbocZZGiD0qBgT1uathz0oMyV/HEku1o+x/ mCmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b2ewwj12; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz40-20020a1709077da800b0078e1246e7d6si4516853ejc.748.2022.11.18.22.39.25; Fri, 18 Nov 2022 22:39:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b2ewwj12; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231351AbiKSGjU (ORCPT + 68 others); Sat, 19 Nov 2022 01:39:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiKSGjS (ORCPT ); Sat, 19 Nov 2022 01:39:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3691B31EF8; Fri, 18 Nov 2022 22:39:18 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C9FCB60A6E; Sat, 19 Nov 2022 06:39:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19EF3C433C1; Sat, 19 Nov 2022 06:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668839957; bh=0ZYQtq1F3G/XBZWSJnxz7MelVEcYtwYDFTPJ7e6klDk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=b2ewwj12u+8qQ9la7a3VkF3YX9TT/oaO1OzVym4OxAOctVF9H92uNbnTz/pC5N7NO 32nan4aq2ko3K4ND6uy23SWIMiGyZ6KLI5TIRfK2OIKAYSYqup4ya3HpdPtEzEnZuo VDFloO/Ol/kOo8IQ7hjvdfQFVi7cxHuuDjwiSgPqHMSctEpoSNA9Vn16dgdewcg+0I 86YugInfEqONPevJZgh3wV3N3em8/En8girb8Wl9vRsvUtHRkCYSY0Izv7YeHC5b7A tFqqRLuIeqTm3GaM8jemhAWSBAvqh+nX9hPxBrAGqXqAMjRNEmN4JXT9+hVgFsE3jt aoUXPhyxfiE3A== From: Kalle Valo To: Kees Cook Cc: Christian Lamparter , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] carl9170: Replace zero-length array of trailing structs with flex-array References: <20221118211146.never.395-kees@kernel.org> Date: Sat, 19 Nov 2022 08:39:11 +0200 In-Reply-To: <20221118211146.never.395-kees@kernel.org> (Kees Cook's message of "Fri, 18 Nov 2022 13:11:47 -0800") Message-ID: <877czrqwhc.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kees Cook writes: > Zero-length arrays are deprecated[1] and are being replaced with > flexible array members in support of the ongoing efforts to tighten the > FORTIFY_SOURCE routines on memcpy(), correctly instrument array indexing > with UBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3. > > Replace zero-length array with flexible-array member. > > This results in no differences in binary output. > > [1] https://github.com/KSPP/linux/issues/78 > > Cc: Christian Lamparter > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: "Gustavo A. R. Silva" > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook Nowadays we include "wifi:" in the subject, but I can add that. But please use this in the future for all wireless patches. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches