Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1570634rwb; Fri, 18 Nov 2022 22:41:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf40V4M9ZSh2lYb38VGIem5oDv7WBfMWZ5GTeAkog9aYNp+DRLlqHocP4eVvnvU9oRsGSCjK X-Received: by 2002:a17:906:8a57:b0:7ad:a030:4915 with SMTP id gx23-20020a1709068a5700b007ada0304915mr8622512ejc.267.1668840090556; Fri, 18 Nov 2022 22:41:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668840090; cv=none; d=google.com; s=arc-20160816; b=UtqzjJoyUArWR15PhX6QVH/VwqE98riQTY/2lnVR8RaMtYVpP9+mJTQ7m8pXqYqcrp 8UYQ4VuLxUauG7pSf2RbptNYFCR3dtgkRK2TRaIEh84vFu1kX/M9Gaw/VPc624Mg05AZ 4smLQSOF1OBhuIcXIIRpssXdSaail3Mfenh2N4/ruaP36Rnbn9FSVxR80a0tkhprignS BduFu77GVVa3SPuhB2cfI0Ix0q2Gh+I1IJ1JrpTtrkgx8g+ILmGjLcBsCqWNYqFMKzT2 cXVRyv0G0BrT1Xfe2rjZsXxtOxAf0refRyjR2U30+2IpmL/nrqaU7JLF4U4RxoFkOB44 wbhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=HuKWEaEtUUkQ3vRUNgnzS0CC7b4QzYoVj5L6j8Uehgw=; b=nP4Ue4IbXX68Bpkbs1Az5waaxkrvHG1kgQeGnYJhnQJkcSeiq+Uj+NmCHs4twbXc6D qtBQ5KyBcKRHt5oOTf47+lcfFgPmP1IlaiALdDz3XvXNHCOZCq1fp/hqRi+tCl8GUlLp IlAlkIUNIfQ8TPqlpR8F85lFCE14IG3ZQPM4RgrOFw4CaDy8cwkBYRv/piHfMlFe0Tax xiHD5Vk/MSMY7MZ/EhWo376e1s/DCu9Hyamg6Zmf5OzHEZc7+1vATO2Fei/GA56HMbTN H980UUj00+JzgTZK1drGZWBuzyuXkdVcgmnvsU6TeedB7fYq9tAKwfaNJuig6QOkdXux cAuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PVN7pS/S"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t13-20020a170906178d00b007aeef4dd9f3si3882559eje.305.2022.11.18.22.41.13; Fri, 18 Nov 2022 22:41:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PVN7pS/S"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232089AbiKSGlL (ORCPT + 68 others); Sat, 19 Nov 2022 01:41:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbiKSGlJ (ORCPT ); Sat, 19 Nov 2022 01:41:09 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE6BA13CA; Fri, 18 Nov 2022 22:41:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55EBA60A73; Sat, 19 Nov 2022 06:41:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ACF8C433D6; Sat, 19 Nov 2022 06:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668840066; bh=ZeqWS3qlxBPkQlLxIdswf7hLuV3mbyIpTRc3e2a1flE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PVN7pS/StHDC8nqh91wKoPK4gJL2fVkFtwNv/G2XVFvKaVCGVmI3gC+PgkUcIo/Fm MU7LL0eL51JvmxhLy/KTMyF+Fvi9WYCNJyql22Bp+KmCI77upsvWri+TTlhxSoIKBp DJIhOGjszVvFO9Lc/LlPwgJsg/pMvUJtBo2cuNUBKjS4xavooRBPxQ2LuTOd+J8GeM RQkovpx6aX/psuZq8emOysPjFClkKfTbK0qZz9fijAy8Dp7mt+/1REP9P+JO7Ki0p5 iK3Oc865hrybBYcfzFBHc8eg3FCgwuVY6ZDVMV6MTYzuaInP12Or3Ogj8qONtQpodt hUZOIq6U2pkmQ== From: Kalle Valo To: Kees Cook Cc: Christian Lamparter , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] p54: Replace zero-length array of trailing structs with flex-array References: <20221118234240.gonna.369-kees@kernel.org> Date: Sat, 19 Nov 2022 08:41:02 +0200 In-Reply-To: <20221118234240.gonna.369-kees@kernel.org> (Kees Cook's message of "Fri, 18 Nov 2022 15:42:44 -0800") Message-ID: <87zgcnphtt.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kees Cook writes: > Zero-length arrays are deprecated[1] and are being replaced with > flexible array members in support of the ongoing efforts to tighten the > FORTIFY_SOURCE routines on memcpy(), correctly instrument array indexing > with UBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3. > > Replace zero-length array with flexible-array member. > > This results in no differences in binary output (most especially because > struct pda_antenna_gain is unused). The struct is kept for future > reference. > > [1] https://github.com/KSPP/linux/issues/78 > > Cc: Christian Lamparter > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: "Gustavo A. R. Silva" > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook I'll add "wifi:". -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches