Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CACT4oucG2z14214jWGJj9XZ5cYMnQpw9CACHvPZ09cbL7m9z_g@mail.gmail.com>
 <100b06a944de88a4b80119c5a2024e0e59cf5243.camel@sipsolutions.net>
 <CACT4oufKgUG5n6Ocgi6r-Z=+Nt9vNVK1e5dJDccogmd8h7xM8Q@mail.gmail.com>
 <5c47143aea07c34dbe95fdb2cab677f2a7a753fb.camel@sipsolutions.net>
 <CACT4ouduybj2Xn_=cgZynf7kF_7tx4cjydkWoTrCAg2=ujR2Tg@mail.gmail.com> <122752227576c059d2b1660934d57e991e7d33c8.camel@sipsolutions.net>
In-Reply-To: <122752227576c059d2b1660934d57e991e7d33c8.camel@sipsolutions.net>
From:   =?UTF-8?B?w43DsWlnbyBIdWd1ZXQ=?= <ihuguet@redhat.com>
Date:   Mon, 21 Nov 2022 12:08:01 +0100
Message-ID: <CACT4oufZpLToemYLHcnQ+hAa=SAbhJT0QxKYjs9fNWV8frsMtg@mail.gmail.com>
Subject: Re: iwlwifi: AC9560 firmware crash with iwlwifi-QuZ-a0-jf-b0 versions
 above 55
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     gregory.greenman@intel.com, golan.ben.ami@intel.com,
        jonathan.sade@intel.com,
        Linux List Kernel Mailing <linux-wireless@vger.kernel.org>,
        linux-bluetooth@vger.kernel.org,
        Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
        Laura Trivelloni <ltrivell@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 21, 2022 at 11:42 AM Johannes Berg
<johannes@sipsolutions.net> wrote:
>
> On Mon, 2022-11-21 at 09:32 +0100, =C3=8D=C3=B1igo Huguet wrote:
> >
> > > --- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
> > > +++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
> > > @@ -1119,6 +1119,11 @@ int iwl_read_ppag_table(struct iwl_fw_runtime =
*fwrt, union iwl_ppag_table_cmd *c
> > >          int i, j, num_sub_bands;
> > >          s8 *gain;
> > >
> > > +       /* many firmware images for JF lie about this */
> > > +       if (CSR_HW_RFID_TYPE(fwrt->trans->hw_rf_id) =3D=3D
> > > +           CSR_HW_RFID_TYPE(CSR_HW_RF_ID_TYPE_JF))
> > > +               return -EOPNOTSUPP;
> > > +
> > >          if (!fw_has_capa(&fwrt->fw->ucode_capa, IWL_UCODE_TLV_CAPA_S=
ET_PPAG)) {
> > >                  IWL_DEBUG_RADIO(fwrt,
> > >                                  "PPAG capability not supported by FW=
, command not sent.\n");
> > >
> > >
> > > johannes
> > >
> >
> > Sorry for the delay with this, I had some issues with the hardware.
> >
> > Using this workaround it doesn't show any errors and I can connect.
>
> OK.
>
> > However, using iwlwifi-QuZ-a0-jf-b0-74 from linux-firmware I get lots
> > of errors, both with this patch applied and without it. Maybe the
> > driver needs some changes?
> > I get stack traces, fw dumps and message `iwlwifi 0000:00:14.3: Failed
> > to send MAC context (action:1): -5`
>
> Probably some other error?
>
> > What would you recommend to do? It seems you didn't like this solution
> > very much (and, as I say, it doesn't work with fw 74)
>
>
> Well I think we still need this solution even if I didn't like it, and

Will you post the patch?

> the fw 74 seems to be a different issue - could you post more info about
> separately?

Sure, will do in a few hours, thanks!

>
> johannes
>


--=20
=C3=8D=C3=B1igo Huguet