Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5940158rwb; Tue, 22 Nov 2022 06:55:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf74DXEtZ+6EFhj11+0T0DKmhY9xuabX9773HEtZwYhGISX5z1C7Z0koUgU/T8YTH0H3JipH X-Received: by 2002:aa7:d74c:0:b0:461:b952:8932 with SMTP id a12-20020aa7d74c000000b00461b9528932mr12959228eds.104.1669128929751; Tue, 22 Nov 2022 06:55:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669128929; cv=none; d=google.com; s=arc-20160816; b=Vg2ziQXMsI3fhndjqZsrznuESHNhs9b3CQsT8Sc1L7Lv7gRf/ZR2ZxLVJHZBiIhzir nVraIS5rfmiGfW0sMC4JyUHAAtl0zPF5L1s+NaMlYhTbLSq8TuFUtKBzbLTc4MOwKACk 1Ys/jkf1uWAlMVyxcW6rGXRRHELgyhRlummgxdCJ1k+AgcX0Pb+DhrHG4RZqwZvjw5uL Yh+ENAopdplk840MVpaiv6mvj+0fAN+c/kUpSzejDRB1gSXizYUfg3OlUYHIgHf7kESf IaccdH07E/vw6aTwfugZu5U3dwBiwmLxeevl4cnSnI/reQDOticqfQjFLAS9j/Dw4l4D rfhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/dybKfChi/+d7OPKnE2rmef0Lq7KuoLknfLczEzSLlg=; b=ez4USWTStmtvrz/sy1AWVE92/IhVPjiiym6AvsCgs9BOzsVBg0gA9yrbnIWa2bwgvw TDjITF+GKVAcNOeYDfTXBcet9+tIYKg21KvDn8sHyu/PlMuq1llUr3Novsrp8sCWilp8 U3/GqPQYtsovm5FTjNF86D1Bym7LfKJCK7pnn8e9EfDZzK0CpP1dI54npYMO9qr5DRLl P8ADgFKJtgDRttmoTJtAEhT7qYpGboIyLc2J82+b0c4wA9ecoINOQNxWi3KWBK6T5nSZ Doc7oQrXSU7IdQNLqhhB9Lh8S8KrfokzN/IJk81dH+V7JJXhKdfGmhbDlumDGZmbSc0I lsIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a26-20020a50ff1a000000b00461dca37cd0si10202178edu.126.2022.11.22.06.55.12; Tue, 22 Nov 2022 06:55:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234052AbiKVOyB (ORCPT + 68 others); Tue, 22 Nov 2022 09:54:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233626AbiKVOxZ (ORCPT ); Tue, 22 Nov 2022 09:53:25 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B3DA1A22F for ; Tue, 22 Nov 2022 06:52:58 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxUdc-0006Lo-4p; Tue, 22 Nov 2022 15:52:40 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oxUdY-005s7q-Ts; Tue, 22 Nov 2022 15:52:37 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oxUdX-00H3kZ-Jd; Tue, 22 Nov 2022 15:52:35 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Johannes Berg , Alexander Hochbaum , Da Xue , Po-Hao Huang , Viktor Petrenko , Sascha Hauer Subject: [PATCH v3 02/11] rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Date: Tue, 22 Nov 2022 15:52:17 +0100 Message-Id: <20221122145226.4065843-3-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221122145226.4065843-1-s.hauer@pengutronix.de> References: <20221122145226.4065843-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org rtw_fw_beacon_filter_config() is called once with rtwdev->mutex held and once without the mutex held. Call it consistently with rtwdev->mutex held. Signed-off-by: Sascha Hauer --- drivers/net/wireless/realtek/rtw88/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 07578ccc4bab3..776a9a9884b5d 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -487,8 +487,8 @@ static int rtw_ops_sta_remove(struct ieee80211_hw *hw, { struct rtw_dev *rtwdev = hw->priv; - rtw_fw_beacon_filter_config(rtwdev, false, vif); mutex_lock(&rtwdev->mutex); + rtw_fw_beacon_filter_config(rtwdev, false, vif); rtw_sta_remove(rtwdev, sta, true); mutex_unlock(&rtwdev->mutex); -- 2.30.2