Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Arend van Spriel <arend.vanspriel@broadcom.com>
Cc:     gregory.greenman@intel.com, johannes@sipsolutions.net,
        linux-wireless@vger.kernel.org, Ilan Peer <ilan.peer@intel.com>
Subject: Re: [PATCH 1/9] wifi: iwlwifi: mvm: Advertise EHT capabilities
References: <20221120170039.1788067-1-gregory.greenman@intel.com>
        <20221120185147.73b38ef7c70a.I214005645f3da21d8f2458a70355deeca04a19e8@changeid>
        <87wn7o8f8x.fsf@kernel.org>
        <4aa47c8c-925e-69b2-5205-4605c3dd8122@broadcom.com>
Date:   Tue, 22 Nov 2022 17:25:34 +0200
In-Reply-To: <4aa47c8c-925e-69b2-5205-4605c3dd8122@broadcom.com> (Arend van
        Spriel's message of "Tue, 22 Nov 2022 14:48:35 +0100")
Message-ID: <8735ab8101.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Arend van Spriel <arend.vanspriel@broadcom.com> writes:

> On 11/21/2022 5:05 PM, Kalle Valo wrote:
>> gregory.greenman@intel.com writes:
>>
>>> From: Ilan Peer <ilan.peer@intel.com>
>>>
>>> Add support for advertising EHT capabilities is supported by
>>> device SKU and not disabled by module parameters.
>>
>> I'm not really understanding what the commit log is saying, some cleanup
>> would be nice.
>
> Would it be more clear when it would say: "EHT capabilities *if*
> supported by device...."

Hehe, indeed it would :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches