Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3448c815-f077-dcfe-9eaa-10ae9be2a8df@warmcat.com>
Date:   Thu, 24 Nov 2022 14:16:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: AP6275 / bcm43752 pcie on mainline brcmf
Content-Language: en-US
To:     Arend van Spriel <arend.vanspriel@broadcom.com>,
        Shengyu Qu <wiagn233@outlook.com>
Cc:     franky.lin@broadcom.com, linux-wireless@vger.kernel.org
References: <TY3P286MB26114DD461F50814980453E598029@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
 <18470a1e910.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <TY3P286MB26115A58795F264893CCB40198029@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
 <184720fc920.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <TY3P286MB26118BD94839F752CADCCF5298079@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
 <625f1d5d-e137-7ad7-96b9-92035e87df8b@broadcom.com>
 <638afa8e-a393-410c-3182-0d8e9b6da17d@warmcat.com>
 <1848793db88.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <3a562a50-0cef-4879-3691-3258596f5213@warmcat.com>
 <1cbb3bf5-fd70-e9db-2405-640178862857@broadcom.com>
 <6c3f592e-3e20-edef-ce7a-cde8988eef2d@warmcat.com>
 <9fe8caec-453a-28c1-04d3-5966200b8db1@broadcom.com>
 <f80c4a64-d987-0f59-418d-adf419fcb054@warmcat.com>
 <56fbcc03-b5dc-34b2-f15a-13c46447ffa0@broadcom.com>
 <d04547d3-4081-4047-3206-6d7c750720dc@warmcat.com>
 <41158f1f-b281-8d77-c5f3-f67adb0b2fde@broadcom.com>
From:   Andy Green <andy@warmcat.com>
In-Reply-To: <41158f1f-b281-8d77-c5f3-f67adb0b2fde@broadcom.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11/24/22 13:47, Arend van Spriel wrote:
> On 11/24/2022 1:54 PM, Andy Green wrote:
>> [   17.202348] brcmfmac: brcmf_escan_prep ### List of SSIDs to scan ### 1
>> [   17.202350] brcmfmac: brcmf_escan_prep 0: Broadcast scan
>> [   17.202352] brcmfmac: brcmf_fil_iovar_data_set ifidx=0, name=escan, 
>> len=180
>> [   17.204223] brcmfmac: brcmf_fil_cmd_data Firmware error: 
>> BCME_VERSION (-37)
>> root@inmusic-az04-mpc:~# [   44.202645] ieee80211 phy0: 
>> brcmf_run_escan: error (-52)
>> [   44.202649] ieee80211 phy0: brcmf_cfg80211_scan: scan error (-52)
> 
> The root cause is easy. Basically the brcmfmac driver is not on par with 
> the firmware. brcmfmac uses escan api version 1 and firmware expects 
> version 2. Fixing it is going to be more difficult. Things start to 

It seems so.

> diverge on firmware API level. I already had a patch on the shelf 
> supporting version 2, but it does not match the API your firmware expects.
> 
> I was working on supporting multiple vendors, but I need some rework. 
> The scanning issue confirms the need for per-vendor support. Hopefully I 
> can spend some time on it.

If it makes sense for you, I'm willing take a look at your alpha patch 
with the idea to align with what the OOT driver does for scan, but I'm 
not sure how intricate wading in there is going to get.

I'd need at least some guidance about how to detect which api stack it 
wants dynamically if there's more than one "version 2" and likely some 
hand-holding about firmware or soc-specific things in places.

-Andy