Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCHv2 4/8] wifi: ath11k: remap ce register space for IPQ5018
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20221122132152.17771-5-quic_kathirve@quicinc.com>
References: <20221122132152.17771-5-quic_kathirve@quicinc.com>
To:     Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Sriram R <quic_srirrama@quicinc.com>,
        Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <166937636895.32083.4258390402302531375.kvalo@kernel.org>
Date:   Fri, 25 Nov 2022 11:39:31 +0000 (UTC)
Precedence: bulk

Karthikeyan Kathirvel <quic_kathirve@quicinc.com> wrote:

> In IPQ5018 ce register space is moved out of wcss unlike
> ipq8074 or ipq6018 and the space is not contiguous,
> hence remap the CE registers to a new space to access them.
> 
> Register read/write is modified to check if the register to be written
> falls in the CE register space and corresponding register is written.
> Also adjust the interrupt register address to ce irq enable/disable.
> 
> Tested-on : IPQ5018 hw1.0 AHB WLAN.HK.2.6.0.1-00861-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> Co-developed-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
> Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

This patch added a new checkpatch warning:

drivers/net/wireless/ath/ath11k/ahb.c:287: Alignment should match open parenthesis

I fixed that in the pending branch.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20221122132152.17771-5-quic_kathirve@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches