Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <19ab38b6-999a-a485-814e-297f7929b806@gmail.com>
Date:   Fri, 25 Nov 2022 20:24:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 2/2] wifi: rtl8xxxu: Introduce rtl8xxxu_update_ra_report
To:     Ping-Ke Shih <pkshih@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     Jes Sorensen <Jes.Sorensen@gmail.com>
References: <00489244-ba7c-797a-28f0-8788a40f7974@gmail.com>
 <ee44c114-e7ba-797e-f7a8-8a8dde7d098a@gmail.com>
 <7afa29a186904e5e901ca711671e8421@realtek.com>
Content-Language: en-US
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <7afa29a186904e5e901ca711671e8421@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/11/2022 10:13, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> Sent: Thursday, November 24, 2022 5:34 AM
>> To: linux-wireless@vger.kernel.org
>> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>
>> Subject: [PATCH 2/2] wifi: rtl8xxxu: Introduce rtl8xxxu_update_ra_report
>>
>> The ra_report struct is used for reporting the TX rate via
>> sta_statistics. The code which fills it out is duplicated in two
>> places, and the RTL8188EU will need it in a third place. Move this
>> code into a new function rtl8xxxu_update_ra_report.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> ---
>> This patch should be applied after my other patch:
>> "[PATCH v2] wifi: rtl8xxxu: Fix use after rcu_read_unlock in rtl8xxxu_bss_info_changed"
>> ---
>>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 105 ++++++++----------
>>  1 file changed, 45 insertions(+), 60 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> index 1c29d0bf09e2..2c8798cb3b4b 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> @@ -4598,6 +4598,32 @@ static void rtl8xxxu_set_aifs(struct rtl8xxxu_priv *priv, u8 slot_time)
>>  	}
>>  }
>>
>> +static void rtl8xxxu_update_ra_report(struct rtl8xxxu_ra_report *rarpt,
>> +				      u8 rate, u8 sgi, u8 bw)
>> +{
>> +	u8 mcs, nss;
>> +
>> +	rarpt->txrate.flags = 0;
>> +
>> +	if (rate < DESC_RATE_MCS0) {
> 
> I think 'if (rate <= DESC_RATE_54M)' would be more reasonable, because 
> rtl8xxxu_legacy_ratetable[] are list of legacy rates.
> 
Okay.