Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp14900105rwb; Mon, 28 Nov 2022 06:08:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf60adY83DEBLe9EZSQJxBz/JAm2DCq4oL0FQumznwdCTg1YBBNX2Q9GWQ59lSwoEQBkl6An X-Received: by 2002:a17:906:7d50:b0:79e:4880:dd83 with SMTP id l16-20020a1709067d5000b0079e4880dd83mr33551140ejp.166.1669644538691; Mon, 28 Nov 2022 06:08:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669644538; cv=none; d=google.com; s=arc-20160816; b=zK/66UF86KnFpMDpCC8i5Mh2IzBQgiRY1jpXfptl4vgShZyOQ3kP2NRqc58MmZlkdD E20a2xP9lukZHNHkmdIlwVeP2hsSfDHqlwjcZeAL8g4wfJPDLnAd0Hprh1d6ytSmHrEj gtPYwrrVSYI5LhKAs5FjkzQlgK9LNxtB3KduK6mU7qjJvvHIQ1s1dUTotR+nUaBzpMPz hOZ4zdhIENNc/I74nn7xlRRdCwpJ4VVE5PCU/kfZsAD1N5mWcjlSE0o1ZCxRATpdpuzz EnVvmoSc+rIgC9amfQbdvH7zLQ25pUERoyGQZ8J9mmPYrLHR1/+tkypX3L+4PMX2+elh yrwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=qjiDG8enTH/TUYWByN8Kk5elVk/DYdoJ9oHB0YGElOo=; b=SPdaUo+N1Ylw/U1keFa+TBD0f80fYX+X0qhgN92Pfy/3gOCQJfc3Y87wNNQSMjti1Y SEwQshvmFtDdChZ1/kQPQAk3YnYjLf87qP85sYmGqsusptO70lRPcUi6wT0d8Az6LDHj Dj3dzYVD5SOKzQT2DTbYCcTRL8546o1aP8qjWwapByy4VJ0WuD4hcwS6EuNMJaDHt/YL iXCQ9fmoW+Jc/kk+o89mECnSdUqtK0UH0D9m4yo2sL2wISERTONyim7TL3NYPovyCrTQ TivYTrk3ijej1gOYLzGst5wxU3qxbY/HrEKmt/wvMygTRFFJz6nI6Nmp9oo2q/YC6e9V n06A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="O/sKEoga"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc36-20020a1709071c2400b007b8b7da648dsi9725466ejc.658.2022.11.28.06.08.28; Mon, 28 Nov 2022 06:08:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="O/sKEoga"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232241AbiK1N5m (ORCPT + 67 others); Mon, 28 Nov 2022 08:57:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232238AbiK1N5S (ORCPT ); Mon, 28 Nov 2022 08:57:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3E9209B1 for ; Mon, 28 Nov 2022 05:57:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C22B610A7 for ; Mon, 28 Nov 2022 13:57:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DAB9C433D6; Mon, 28 Nov 2022 13:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669643836; bh=Wgd4ZqdNPCxDsHQQCn8t/PzEfvkc8SojOes48tArWtE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=O/sKEogaGIEQ5XDfJ/FIPvp5lY/E0dfog9eWxSe/JAFEN8DC5rJMXH5oCTEG5cu4G swzMSMcF6UKo54/iN7fVn8srQXc5Rjr+jwbjOc0b6TcGylfk3oWvvFniQAEk/KuoIv UZWIRBYxHngST0USWA/1jBMVA5A0XW+GcYPVjYo2inUYGKGFQZ7oUo4eRR7l9sqCrc bAS8Fr0+9rMbljX+Z+BJPcxXVgqYGot3smNYMezXac6MO7xTpLwwvgN467O4tDF5rP HYMw95zOmeB8+TVw954dyLjtmfCgUqiQtpbPmqMN8TP8mvH3c/rgaIr/5ggqaFlgVd ZuOVDIyVy4V2g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: rtl8xxxu: Fix use after rcu_read_unlock in rtl8xxxu_bss_info_changed From: Kalle Valo In-Reply-To: <3c82ad09-7593-3be1-1d2c-e58505fb43cb@gmail.com> References: <3c82ad09-7593-3be1-1d2c-e58505fb43cb@gmail.com> To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Jes Sorensen , Ping-Ke Shih User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166964383356.4701.9676468780142047023.kvalo@kernel.org> Date: Mon, 28 Nov 2022 13:57:15 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bitterblue Smith wrote: > Commit a8b5aef2cca1 ("wifi: rtl8xxxu: gen2: Enable 40 MHz channel width") > introduced a line where the pointer returned by ieee80211_find_sta() is > used after rcu_read_unlock(). > > Move rcu_read_unlock() a bit lower to fix this. > > Fixes: a8b5aef2cca1 ("wifi: rtl8xxxu: gen2: Enable 40 MHz channel width") > Signed-off-by: Bitterblue Smith > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 7927afb5e27b wifi: rtl8xxxu: Fix use after rcu_read_unlock in rtl8xxxu_bss_info_changed -- https://patchwork.kernel.org/project/linux-wireless/patch/3c82ad09-7593-3be1-1d2c-e58505fb43cb@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches