Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH net] wifi: plfxlc: fix potential memory leak in
 __lf_x_usb_enable_rx()
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20221119051900.1192401-1-william.xuanziyang@huawei.com>
References: <20221119051900.1192401-1-william.xuanziyang@huawei.com>
To:     Ziyang Xuan <william.xuanziyang@huawei.com>
Cc:     <srini.raju@purelifi.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <166964379732.4701.17323833019999253439.kvalo@kernel.org>
Date:   Mon, 28 Nov 2022 13:56:39 +0000 (UTC)
Precedence: bulk

Ziyang Xuan <william.xuanziyang@huawei.com> wrote:

> urbs does not be freed in exception paths in __lf_x_usb_enable_rx().
> That will trigger memory leak. To fix it, add kfree() for urbs within
> "error" label. Compile tested only.
> 
> Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>

Patch applied to wireless-next.git, thanks.

895b3b06efc2 wifi: plfxlc: fix potential memory leak in __lf_x_usb_enable_rx()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20221119051900.1192401-1-william.xuanziyang@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches