Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Kalle Valo <kvalo@kernel.org>
CC:     Kevin Yang <kevin_yang@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H
Thread-Topic: [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H
Thread-Index: AQHY+wxMFA5vmLa6FUaozuPdYh37Sq5UZScwgAC00yA=
Date:   Tue, 29 Nov 2022 00:22:40 +0000
Message-ID: <6444fb9949e14656b3ccf0adb6babb63@realtek.com>
References: <20221118051042.29968-1-pkshih@realtek.com>
        <20221118051042.29968-5-pkshih@realtek.com> <87o7sr5hq9.fsf@kernel.org>
In-Reply-To: <87o7sr5hq9.fsf@kernel.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering
 rules found
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2022/11/28_=3F=3F_10:37:00?=
x-kse-bulkmessagesfiltering-scan-result: protection disabled
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9
X-KSE-Attachment-Filter-Triggered-Rules: Clean
X-KSE-Attachment-Filter-Triggered-Filters: Clean
X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Monday, November 28, 2022 9:31 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kevin Yang <kevin_yang@realtek.com>; linux-wireless@vger.kernel.org
> Subject: Re: [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H
> 
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
> >
> > Process C2H(s) related to MCC (multi-channel concurrency). These handling,
> > which either call rtw89_complete_cond() or show message in debug mode, can
> > be considered atomic/lock-free. So, they should be safe to be processed
> > directly after C2H pre-check in previous patch.
> >
> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> [...]
> 
> > +static
> > +void (* const rtw89_mac_c2h_mcc_handler[])(struct rtw89_dev *rtwdev,
> > +					   struct sk_buff *c2h, u32 len) = {
> > +	[RTW89_MAC_C2H_FUNC_MCC_RCV_ACK] = rtw89_mac_c2h_mcc_rcv_ack,
> > +	[RTW89_MAC_C2H_FUNC_MCC_REQ_ACK] = rtw89_mac_c2h_mcc_req_ack,
> > +	[RTW89_MAC_C2H_FUNC_MCC_TSF_RPT] = rtw89_mac_c2h_mcc_tsf_rpt,
> > +	[RTW89_MAC_C2H_FUNC_MCC_STATUS_RPT] = rtw89_mac_c2h_mcc_status_rpt,
> > +};
> 
> static const?
> 

These are function pointers, so const is before instance name, 
i.e. '... const rtw89_mac_c2h_mcc_handler ..'

Checking it with objdump, which shows '.rodata' also:

$ objdump -t mac.o | grep rtw89_mac_c2h_mcc_handler
00000000000000a0 l     O .rodata        0000000000000020 rtw89_mac_c2h_mcc_handler

--
Ping-Ke